Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview #22828

Merged

Conversation

davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Feb 28, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @davidgamero Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 28, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    workflow.json 2022-10-11-preview(ff1ecc7) 2022-04-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-10 package-preview-2022-10(ff1ecc7) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L495


    The following errors/warnings exist before current PR submission:

    Rule Message
    DeleteResponseBodyEmpty The delete response body must be empty.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L408
    ⚠️ PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L38
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getgithuboauthinfo' in:'GitHubOAuth'. Consider updating the operationId
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L77
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L89
    ⚠️ GetInOperationName 'GET' operation 'GitHubOAuthCallback' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L124
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L165
    ⚠️ PageableOperation Based on the response model schema, operation 'ListGitHubOAuth' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L165
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L208
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L247
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Workflows
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L280
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L292
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L332
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L347
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L389
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L432
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L692
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L971
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L974
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 12 Errors, 0 Warnings failed [Detail]

    Tag package-preview-2022-10; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 11, untested: 0, failed: 6, passed: 5

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    CLIENT_ERROR statusCode: 401,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: Workflow_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: code
    Source: response
    OperationId: Workflow_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: message
    Source: response
    OperationId: Workflow_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: details
    Source: response
    OperationId: Workflow_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DevHub/workflows/workflowpoabgf' under resource group 'apiTest-pJqjhC-22828' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Workflow_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DevHub/workflows/workflowpoabgf' under resource group 'apiTest-pJqjhC-22828' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Workflow_UpdateTags
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DevHub/locations/generatePreviewArtifacts/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GeneratePreviewArtifacts
    SERVER_ERROR statusCode: 500,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: GitHubOAuthCallback
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: code
    Source: response
    OperationId: GitHubOAuthCallback
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: message
    Source: response
    OperationId: GitHubOAuthCallback
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: details
    Source: response
    OperationId: GitHubOAuthCallback
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DevHub/locations/githuboauth/getGitHubOAuthInfo/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: GitHubOAuth
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 28, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/devhub/armdevhub - 0.4.0
    +	Type of `GitHubWorkflowProfile.AuthStatus` has been changed from `*ManifestType` to `*AuthorizationStatus`

    azure-sdk-for-js - @azure/arm-devhub - 1.0.0-beta.3
    +	Interface Workflow no longer has parameter namespace
    +	Type of parameter authStatus of interface Workflow is changed from ManifestType to AuthorizationStatus
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4eaa726. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/devhub/armdevhub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `GitHubWorkflowProfile.AuthStatus` has been changed from `*ManifestType` to `*AuthorizationStatus`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `AuthorizationStatus` with values `AuthorizationStatusAuthorized`, `AuthorizationStatusError`, `AuthorizationStatusNotFound`
      info	[Changelog] - New enum type `DockerfileGenerationMode` with values `DockerfileGenerationModeDisabled`, `DockerfileGenerationModeEnabled`
      info	[Changelog] - New enum type `GenerationLanguage` with values `GenerationLanguageClojure`, `GenerationLanguageCsharp`, `GenerationLanguageErlang`, `GenerationLanguageGo`, `GenerationLanguageGomodule`, `GenerationLanguageGradle`, `GenerationLanguageJava`, `GenerationLanguageJavascript`, `GenerationLanguagePhp`, `GenerationLanguagePython`, `GenerationLanguageRuby`, `GenerationLanguageRust`, `GenerationLanguageSwift`
      info	[Changelog] - New enum type `GenerationManifestType` with values `GenerationManifestTypeHelm`, `GenerationManifestTypeKube`
      info	[Changelog] - New enum type `ManifestGenerationMode` with values `ManifestGenerationModeDisabled`, `ManifestGenerationModeEnabled`
      info	[Changelog] - New enum type `WorkflowRunStatus` with values `WorkflowRunStatusCompleted`, `WorkflowRunStatusInprogress`, `WorkflowRunStatusQueued`
      info	[Changelog] - New function `*DeveloperHubServiceClient.GeneratePreviewArtifacts(context.Context, string, ArtifactGenerationProperties, *DeveloperHubServiceClientGeneratePreviewArtifactsOptions) (DeveloperHubServiceClientGeneratePreviewArtifactsResponse, error)`
      info	[Changelog] - New struct `ArtifactGenerationProperties`
      info	[Changelog] - New field `ArtifactGenerationProperties` in struct `WorkflowProperties`
      info	[Changelog] - New field `WorkflowRunStatus` in struct `WorkflowRun`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 36 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4eaa726. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.4` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-devhub [View full logs]  [Release SDK Changes]
      info	[Changelog]   - Initial Release
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4eaa726. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-devhub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface ArtifactGenerationProperties
      info	[Changelog]   - Added Interface GeneratePreviewArtifactsOptionalParams
      info	[Changelog]   - Added Type Alias AuthorizationStatus
      info	[Changelog]   - Added Type Alias DockerfileGenerationMode
      info	[Changelog]   - Added Type Alias GeneratePreviewArtifactsResponse
      info	[Changelog]   - Added Type Alias GenerationLanguage
      info	[Changelog]   - Added Type Alias GenerationManifestType
      info	[Changelog]   - Added Type Alias ManifestGenerationMode
      info	[Changelog]   - Added Type Alias WorkflowRunStatus
      info	[Changelog]   - Interface Workflow has a new optional parameter appName
      info	[Changelog]   - Interface Workflow has a new optional parameter builderVersion
      info	[Changelog]   - Interface Workflow has a new optional parameter dockerfileGenerationMode
      info	[Changelog]   - Interface Workflow has a new optional parameter dockerfileOutputDirectory
      info	[Changelog]   - Interface Workflow has a new optional parameter generationLanguage
      info	[Changelog]   - Interface Workflow has a new optional parameter imageName
      info	[Changelog]   - Interface Workflow has a new optional parameter imageTag
      info	[Changelog]   - Interface Workflow has a new optional parameter languageVersion
      info	[Changelog]   - Interface Workflow has a new optional parameter manifestGenerationMode
      info	[Changelog]   - Interface Workflow has a new optional parameter manifestOutputDirectory
      info	[Changelog]   - Interface Workflow has a new optional parameter manifestType
      info	[Changelog]   - Interface Workflow has a new optional parameter namespacePropertiesArtifactGenerationPropertiesNamespace
      info	[Changelog]   - Interface Workflow has a new optional parameter namespacePropertiesGithubWorkflowProfileNamespace
      info	[Changelog]   - Interface Workflow has a new optional parameter port
      info	[Changelog]   - Interface WorkflowRun has a new optional parameter workflowRunStatus
      info	[Changelog]   - Added Enum KnownAuthorizationStatus
      info	[Changelog]   - Added Enum KnownDockerfileGenerationMode
      info	[Changelog]   - Added Enum KnownGenerationLanguage
      info	[Changelog]   - Added Enum KnownGenerationManifestType
      info	[Changelog]   - Added Enum KnownManifestGenerationMode
      info	[Changelog]   - Added Enum KnownWorkflowRunStatus
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface Workflow no longer has parameter namespace
      info	[Changelog]   - Type of parameter authStatus of interface Workflow is changed from ManifestType to AuthorizationStatus
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 28, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/devhub/armdevhub Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-devhub https://apiview.dev/Assemblies/Review/0a0d7fd80ea54dfb87ec19ae753ec7c5

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 28, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @davidgamero your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @bfoley13 bfoley13 marked this pull request as ready for review March 1, 2023 14:58
    @bfoley13
    Copy link
    Member

    bfoley13 commented Mar 1, 2023

    @tadelesh Just FYI, for the API breaking change, it was never actually ManifestType in the AuthStatus field in the code base, it was always AuthorizationStatus, so that slipped through the first version API changes. And the API readiness check is going to fail because we have a PR open for the ARM Manifest that wont be signed off until this PR is signed off: https://armmanifest.visualstudio.com/One/_git/Manifest/pullrequest/6409?_a=overview

    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 2, 2023
    @openapi-workflow-bot
    Copy link

    Hi @davidgamero, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Mar 3, 2023
    @ghost
    Copy link

    ghost commented Mar 26, 2023

    Hi, @davidgamero. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Mar 26, 2023
    @davidgamero davidgamero added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed no-recent-activity ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Apr 3, 2023
    @davidgamero
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    Copy link
    Member

    @bfoley13 bfoley13 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @tadelesh @pilor some of these scenarios tested in the pipeline for Service API Readiness will require a subscription to setup a valid connection to github to be used successfully. How can we move this PR forward with that in mind?

    @tadelesh
    Copy link
    Member

    tadelesh commented Apr 7, 2023

    @tadelesh @pilor some of these scenarios tested in the pipeline for Service API Readiness will require a subscription to setup a valid connection to github to be used successfully. How can we move this PR forward with that in mind?

    You could ignore it. I'll merge this PR.

    @tadelesh
    Copy link
    Member

    tadelesh commented Apr 7, 2023

    Breaking change is introduced and approved in this PR: #20868.

    @tadelesh tadelesh merged commit 4eaa726 into main Apr 7, 2023
    @tadelesh tadelesh deleted the davidgamero-developerhub-Microsoft.DevHub-2022-10-11-preview branch April 7, 2023 03:07
    fnuarnav added a commit that referenced this pull request Apr 7, 2023
    …23484)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    fnuarnav added a commit that referenced this pull request Apr 11, 2023
    …23513)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    * fix tag in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    tadelesh pushed a commit that referenced this pull request Apr 13, 2023
    …2023-05-01 (#23485)
    
    * Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23166)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23169)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23170)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23452)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23453)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23471)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23473)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23483)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * use management.auzre.com endpoint
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * fix package version in readme
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (#23484)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * fix tag in readme
    
    * update example with capabilities example
    
    * fix typo
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    …eview/2022-10-11-preview (Azure#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    …2023-05-01 (Azure#23485)
    
    * Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23166)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23169)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23170)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23452)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23453)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23471)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * use old api versionf or operations
    
    * revert Operations example api version
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23473)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (Azure#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (Azure#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (Azure#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (Azure#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23483)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (Azure#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (Azure#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (Azure#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (Azure#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * use management.auzre.com endpoint
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * fix package version in readme
    
    * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23484)
    
    * add container security context property
    
    * update readme tag to previous stable version
    
    * add example with security context
    
    * avocado fix default tag should contain all endpoints
    
    * add back spot priority changes
    
    * use previous stable version as default tag
    
    * prettier fix
    
    * use spaces
    
    * fix error
    
    * use spaces
    
    * fix CI errors
    
    * use altest api version as default for Avocado
    
    * update host to eastus2euap endpoint to check manifest
    
    * MGRP S360 Vuln (Azure#22832)
    
    * Add blockchain to latest profile
    
    * Add additional types
    
    * Fix Swagger issues
    
    * Solve validation
    
    ---------
    
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    
    * use old api versionf or operations
    
    * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)
    
    * added example for the new field
    
    * updated the double ref that was causing build failure
    
    * Fixed PrometheusRuleGroups examples (Azure#23390)
    
    * Fixed PrometheusRuleGroups examples
    
    * One more fix
    
    * Remvoe flattern (Azure#23460)
    
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    
    * Mvad update (Azure#23434)
    
    * Add default value 10 for topContributorCount
    
    * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings
    
    * Update TypeSpec config
    
    * Add back language emitter options
    
    * Fix cspell and model validation errors
    
    ---------
    
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    
    * revert Operations example api version
    
    * add codeowners for Compute Instance swagger (Azure#23437)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (Azure#22828)
    
    * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * start 10-11 preview
    
    * add words
    
    * fix readme version
    
    * update swagger version
    
    * add second putworkflow example
    
    * fix generatepreviewartifactsresponse
    
    * align generate preview artifacts example
    
    * update param locations that got changed
    
    * add x-ms-client-flatten for artifact properties
    
    * Adding WorkflowRunStatus
    
    * Fixing enum name
    
    * add namespace to example
    
    ---------
    
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    
    * Update readme.python.md (Azure#23208)
    
    * fixing async response type for machinelearningservices-2023-02-01-preview (Azure#23105)
    
    * fixing regex pattern and async response type
    
    * remove update to regex
    
    * Fix lint error for Datadog RP (Azure#23477)
    
    * Fix link error for Datadog RP
    
    * Fix version
    
    * merging billing fix to public repo (Azure#23424)
    
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * use management.auzre.com endpoint
    
    * fix package version in readme
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    
    * fix tag in readme
    
    * update example with capabilities example
    
    * fix typo
    
    ---------
    
    Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
    Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
    Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
    Co-authored-by: will <koyasu221b@gmail.com>
    Co-authored-by: Will Huang <huangwill@microsoft.com>
    Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
    Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: David Gamero <david340804@gmail.com>
    Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
    Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
    Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
    Co-authored-by: Gaurav <bang.gourav@gmail.com>
    Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants