[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-03-01 #12231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @yashmuel Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
asafst
reviewed
Dec 30, 2020
...ification/monitor/resource-manager/Microsoft.Insights/stable/2018-03-01/metricAlert_API.json
Show resolved
Hide resolved
asafst
approved these changes
Dec 30, 2020
|
Hi @yashmuel, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
BreakingChangeReviewRequired
and removed
CI-FixRequiredOnFailure
labels
|
Hi @yashmuel, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jan 4, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
JeffreyRichter
approved these changes
Jan 4, 2021
JeffreyRichter
added
the
Approved-BreakingChange
weidongxu-microsoft
approved these changes
Jan 5, 2021
| "default": { | ||
| "description": "BadRequest", | ||
| "schema": { | ||
| "$ref": "../../stable/2016-03-01/alertRules_API.json#/definitions/ErrorResponse" |
There was a problem hiding this comment.
It seems not a good practice to refer to another version (but as it is already done, there might not possible to fix within this version).
Also the response schema is not correct as in LintDiff. It should have an error property, which then contains code and message.
Though it is likely not possible to fix within same version, you might need to suppress.
There was a problem hiding this comment.
@weidongxu-microsoft right.
I've requested a suppression for the LintDiff and also mentioned it in the swagger.
What about the sdk check which fails, what should i do with this? suppression as well?
There was a problem hiding this comment.
You can ignore the CI that without "required" label. They does not block the merge.
As dotnet build, it appears from its log above, fails on some class as azure-sdk-for-net/sdk/monitor/Microsoft.Azure.Management.Monitor/tests/BasicTests/DataCollectionRulesTests.cs, so it is likely not caused by your PR.
There was a problem hiding this comment.
@weidongxu-microsoft cool, so is there anything that blocking me to merge this PR?
Another thing, I've another PR (#12234) with some error about Swagger ApiDocPreview failed, should i fixed this or it's like the sdk?
There was a problem hiding this comment.
I tried to re-run ApiDocPreview CI in the other PR. Anyway this does not block.
Both PR still have LintDiff, which blocks. I think perhaps the suppress is not done correctly. The correct one is perhaps
- suppress: R4007
There was a problem hiding this comment.
This is his github ID. Though I do not think it will be exempted. And monitor had the json https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json, and it is used in current package-2019-06 tag.
There was a problem hiding this comment.
@weidongxu-microsoft
cool, i'll try him.
I've 2 additional PRs that i want to merge, but experiencing the same model validations we had in the current PR,
can you do the same process you did for this one to merge them?
#12371
#12372
There was a problem hiding this comment.
For these you can also contact Arthur.
There was a problem hiding this comment.
sure, will do.
but first you don't have to verify that the failing model validation are false alerts?
There was a problem hiding this comment.
@weidongxu-microsoft talked with Ray and suppressed the modelValidation, can you please help me merge this one?
#12371
|
PrettierCheck fails. |
fixed this. |
…yashmuel-fix-swagger-validations
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
CI-BreakingChange-Python
and removed
CI-FixRequiredOnFailure
labels
weidongxu-microsoft
added
the
Approved-OkToMerge
|
@akning-ms Hi Arthur, could you help merge this PR? Jeffrey approved the breaking changes. I've checked with Ray Chen, that fail on "ModelValication" is false alert (the swagger has a local |
This was referenced Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.