[Hub Generated] Review request for Microsoft.Insights to add version …

…stable/2018-03-01 (#12231) * Fix Azure Metric Alerts Swagger Correctness * added suppresion rule and removed errorResponse * removed isMigrated * renamed suppression rule * trying to fix validation error * Another try to fix swagger * trying to fix swagger validation * trying to pass swagger validation * fixed suppression * fixed space
Azure · Jan 11, 2021 · 8ad116c · 8ad116c
1 parent 2298361
commit 8ad116c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/...cation/monitor/resource-manager/Microsoft.Insights/stable/2018-03-01/metricAlert_API.json b/...cation/monitor/resource-manager/Microsoft.Insights/stable/2018-03-01/metricAlert_API.json
@@ -319,6 +319,12 @@
           },
           "204": {
             "description": "No content: the request was successful, but the response is empty"
+          },
+          "default": {
+            "description": "BadRequest",
+            "schema": {
+              "$ref": "../../stable/2016-03-01/alertRules_API.json#/definitions/ErrorResponse"
+            }
           }
         },
         "x-ms-examples": {
@@ -475,7 +481,6 @@
     "MetricAlertProperties": {
       "required": [
         "enabled",
-        "description",
         "severity",
         "evaluationFrequency",
         "windowSize",
@@ -488,6 +493,7 @@
         },
         "severity": {
           "type": "integer",
+          "format": "int32",
           "description": "Alert severity {0, 1, 2, 3, 4}"
         },
         "enabled": {
@@ -896,6 +902,7 @@
           "description": "Namespace of the metric."
         },
         "timeAggregation": {
+          "type": "string",
           "enum": [
             "Average",
             "Count",
@@ -904,7 +911,7 @@
             "Total"
           ],
           "x-ms-enum": {
-            "name": "AggregationType",
+            "name": "AggregationTypeEnum",
             "modelAsString": true
           },
           "description": "the criteria time aggregation types."

diff --git a/specification/monitor/resource-manager/readme.md b/specification/monitor/resource-manager/readme.md
@@ -587,6 +587,9 @@ directive:
     from: dataCollectionRuleAssociations_API.json
     where: $.paths
     reason: 'Operations API is defined in a separate swagger spec for Microsoft.Insights namespace (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json)'
+  - suppress: R4007
+    from: metricAlert_API.json
+    reason: 'Updating the error response to the new format would be a breaking change.'
   - suppress: R4007
     from: calculateBaseline_API.json
     reason: 'Updating the error response to the new format would be a breaking change.'