Reorganization for config files [Not Ready For Merge] #1215

fearthecowboy · 2017-05-10T17:46:08Z

This is the reorganized layout for the specs repository.

Testing with this should being ASAP;

fearthecowboy · 2017-05-10T17:48:41Z

I'm testing out generating the Azure Resource Schemas from this. More minor changes yet coming, I'm sure.

lmazuel · 2017-05-10T22:23:49Z

@fearthecowboy I have questions if you don't mind:

If I use "specification/resources/resource-manager/readme.md", I will generate one client only. Currently, resources has one client for each file (one for links, one for features, etc.). IOW, they are not using Composite right now, and with this readme.md using "api-version=XXXXXX" will not be compatible. Thoughts? Have you discussed that with the team already?
Is the namespace folder strict? If it's Microsoft.Compute, should I consider this a bug if I found another namespace inside?

Otherwise, looks good to me

fearthecowboy · 2017-05-10T22:34:39Z

Hey @lmazuel

Ideally, you (meaning Python, or any other 'enlightened' generator) woulnd't use the per-RP readme.md files.

I've added a 'batch' mode to autorest (although I think we're going to refactor it a bit more yet), that can process a very large list of swagger files sequentially, and I think it'll be a lot more to your liking. (I'm using it for AzureResourceSchema generation).

In the not too distant future, I think we're going to remove entirely the notion of 'composite' (or merged swagger docs) in favor of individual processing, and allow generators to 'merge' the generation artifacts however they wish (in the case of c#, that's where we'd generate a per-RP client 'sdk' )

The folder structure is intended to be pretty strict (a given RP can have stuff in any namespace, but the resources in a namespace should be only that namespace)

…into reorg

lmazuel · 2017-05-10T22:38:43Z

To be sure I understand, the "batch" more:

Currently if I do --input-file=A ---input-file=B, it creates one unique client right? So for me it's "composite like" (two inputs => one output).
The batch mode will allow me to do --input-file=A ---input-file=B and get two clients?

fearthecowboy · 2017-05-10T22:45:13Z

@lmazuel -- Yes.

Question: Is there ever a case where you want a merged client?

(for an 'work-in-progress' example see https://github.com/Azure/azure-rest-api-specs/blob/702e7033580b6b6b0ab4749f6b8f2f497b997d62/profiles/ResourceSchemas.md )

lmazuel · 2017-05-10T22:46:05Z

@fearthecowboy All network in one client, compute+disk in one client (for instance).

fearthecowboy · 2017-05-10T22:47:54Z

@lmazuel ok, I'm in the office tomorrow -- we should get together sometime in the morning if you're free. I need to make sure we know exactly how you're doing things 🍖

…into reorg

veronicagg

Readme at the root of the repo needs update.
There seem to be 2 folders "Microsoft.Advisor" and "microsoft.advisor" in arm-advisor.

veronicagg · 2017-05-11T20:31:53Z

specification/compute/resource-manager/readme.md

@@ -0,0 +1,87 @@
+# Compute


should the folder for the new specs be named "resource-manager" or "resource-management"?

Is there a definitive reason one way or the other?

I have no strong feelings one way or the other.

Not really, I've seen us use management before, but I just searched around in the Azure docs online and they seem to refer to it as Azure Resource Manager, so let's go with manager. Thanks!

veronicagg · 2017-05-11T21:12:53Z

are all composite files going away with this change, I noticed https://github.com/Azure/azure-rest-api-specs/blob/reorg/specification/insights/compositeInsightsManagementClient.json ?

…into reorg

vishrutshah · 2017-05-16T22:09:21Z

specification/batch/data-plane/readme.md

@@ -28,7 +28,18 @@ These are the global settings for the Batch API.
 # common 
 title: Batch
 description: Batch Client
-api-version: 2017-01-01.4.0
+api-version: 2017-05-01.5.0


Ohh nooo what are these ^M characters?

Windows and it's desperate attempt to get all CRLF when LF will do?

Lemme see if I can eliminate them.

dsgouda · 2017-06-06T17:45:21Z

@olydis, please ensure that all .md files under arm-* directories have the openapi-type flag set to arm, while others are set to default, we may have to make another pass to figure out the data plane ones, but this is the bare minimum.

olydis · 2017-06-09T16:52:33Z

@dsgouda went for data-plane for the data plane ones... since this is gonna roll out in July there should be opportunity to fix the categorization.

dsgouda · 2017-06-13T22:35:45Z

@veronicagg as @olydis mentioned we are starting off with actually marking all specs not under arm* directories of the repo as data-plane specs which would mean we would be running DataPlane specific validation rules over these.
Just want to confirm if you're onboard with this plan.

veronicagg · 2017-06-15T23:24:58Z

@dsgouda I think that's reasonable, we can tune it based on feedback, it's going to anyway be a subset of what we have today, so should be better.

dsgouda · 2017-06-19T23:17:13Z

The CI build script for linter needs to be updated to exclude all jsons under *examples* directories
@vishrutshah are you looking into it?

vishrutshah · 2017-06-20T17:42:27Z

@dsgouda Wouldn't this 3900abb#diff-32008d041c23a0732242a32942c339e4R115 cover that or do we need the changes somewhere else?

…#1346)

salameer · 2017-07-07T20:18:10Z

Folks I see changes requested on this PR and I believe we're going to switch the new structure on Monday, so what that plan for this PR?

salameer · 2017-07-07T20:19:25Z

@olydis, I think you had an action item on the VMSS swagger and where it's going to show up for Networking right?

* Update MD Compute for Python * Group python together * Group Python again * Update Web Readme for Python * Update SQL MD for Python * Update Monitor Mgmt MD for Python * Update Monitor Data MD for Python * Update GraphRBAC MD for Python * Partial update of Network MD for Python * Update full Network for Python * Remove creation of Python from MD

* Fix selection of swagger * Fixing `

fearthecowboy added 2 commits May 10, 2017 10:30

Reorganize Repository

087554c

merged from master

232dda8

msftclas added the cla-not-required label May 10, 2017

fearthecowboy requested review from lmazuel, vishrutshah, olydis, veronicagg and salameer May 10, 2017 17:47

azuresdkci assigned olydis May 10, 2017

fearthecowboy added 2 commits May 10, 2017 13:20

added resourceschemas config

1e41b35

minor fixes

8b3103d

fearthecowboy added 2 commits May 10, 2017 15:37

some fixes

702e703

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …

103bd0f

…into reorg

removed superflous file

f368838

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …

6567a42

…into reorg

veronicagg reviewed May 11, 2017

View reviewed changes

fearthecowboy and others added 5 commits May 16, 2017 09:28

Moving files added to master

23c4b6f

Updated readme

6fdfb5c

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …

f031dcb

…into reorg

fixes

ac14d45

merged and cleand

53acba7

vishrutshah suggested changes May 16, 2017

View reviewed changes

Johannes Bader added 2 commits June 6, 2017 10:12

merge

816fecb

reorg new files

619c90f

Johannes Bader added 3 commits June 6, 2017 11:31

tying stuff up

c123bff

api-version -> tag

8034005

fix up them example urls

2cba92a

Azure deleted a comment from azuresdkci Jun 9, 2017

openapi-type

3b49c82

merge

ec928bd

dsgouda mentioned this pull request Jun 16, 2017

Inspect what rules indicate path not found and fix them if needed Azure/autorest#2314

Closed

Update README.md

28df1d5

olydis force-pushed the reorg branch from f656852 to 28df1d5 Compare June 23, 2017 22:09

olydis and others added 5 commits June 23, 2017 15:21

less misleading tags (due to repeated confusion at the consumer side) (…

dc76261

…#1346)

merge

e179966

rewire refs

d0a11b8

specially tailored network structure

913f848

Merge remote-tracking branch 'azure/master' into reorg

242b95e

lmazuel and others added 5 commits July 7, 2017 14:11

Title extraction from Composite (#1388)

1e4c294

Merge remote-tracking branch 'azure/master' into reorg

284c568

structure

bd19e52

Reorg fixci (#1395)

2fb9a0b

* Fix selection of swagger * Fixing `

fearthecowboy closed this Jul 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganization for config files [Not Ready For Merge] #1215

Reorganization for config files [Not Ready For Merge] #1215

fearthecowboy commented May 10, 2017 •

edited by azuresdkci

Loading

fearthecowboy commented May 10, 2017

lmazuel commented May 10, 2017

fearthecowboy commented May 10, 2017

lmazuel commented May 10, 2017 •

edited

Loading

fearthecowboy commented May 10, 2017

lmazuel commented May 10, 2017

fearthecowboy commented May 10, 2017

veronicagg left a comment

veronicagg May 11, 2017

fearthecowboy May 16, 2017

veronicagg May 18, 2017

veronicagg commented May 11, 2017

vishrutshah May 16, 2017

fearthecowboy May 16, 2017

dsgouda commented Jun 6, 2017 •

edited

Loading

olydis commented Jun 9, 2017

dsgouda commented Jun 13, 2017

veronicagg commented Jun 15, 2017

dsgouda commented Jun 19, 2017

vishrutshah commented Jun 20, 2017

salameer commented Jul 7, 2017

salameer commented Jul 7, 2017

Reorganization for config files [Not Ready For Merge] #1215

Reorganization for config files [Not Ready For Merge] #1215

Conversation

fearthecowboy commented May 10, 2017 • edited by azuresdkci Loading

fearthecowboy commented May 10, 2017

lmazuel commented May 10, 2017

fearthecowboy commented May 10, 2017

lmazuel commented May 10, 2017 • edited Loading

fearthecowboy commented May 10, 2017

lmazuel commented May 10, 2017

fearthecowboy commented May 10, 2017

veronicagg left a comment

Choose a reason for hiding this comment

veronicagg May 11, 2017

Choose a reason for hiding this comment

fearthecowboy May 16, 2017

Choose a reason for hiding this comment

veronicagg May 18, 2017

Choose a reason for hiding this comment

veronicagg commented May 11, 2017

vishrutshah May 16, 2017

Choose a reason for hiding this comment

fearthecowboy May 16, 2017

Choose a reason for hiding this comment

dsgouda commented Jun 6, 2017 • edited Loading

olydis commented Jun 9, 2017

dsgouda commented Jun 13, 2017

veronicagg commented Jun 15, 2017

dsgouda commented Jun 19, 2017

vishrutshah commented Jun 20, 2017

salameer commented Jul 7, 2017

salameer commented Jul 7, 2017

fearthecowboy commented May 10, 2017 •

edited by azuresdkci

Loading

lmazuel commented May 10, 2017 •

edited

Loading

dsgouda commented Jun 6, 2017 •

edited

Loading