Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect what rules indicate path not found and fix them if needed #2314

Closed
dsgouda opened this issue May 31, 2017 · 3 comments
Closed

Inspect what rules indicate path not found and fix them if needed #2314

dsgouda opened this issue May 31, 2017 · 3 comments
Assignees
Labels
P1 - Required Required functionality - not blocking

Comments

@dsgouda
Copy link
Contributor

dsgouda commented May 31, 2017

Some paths returned by validation rules are not found in the document in which case we climb up the path.
While this is helpful, when working on composite documents the rule may end up pointing to a node that is common for all component files (eg. definitions)
We need to run the validator against the entire repo and inspect which rules run into this issue and evaluate if we can fix the paths returned by these rules so we can accurately point them using the vscode linter extension

Thanks @veronicagg for finding this issue.

A bunch of the rules could be cured of this issue by #2313

@dsgouda dsgouda added the linter label May 31, 2017
@dsgouda dsgouda self-assigned this May 31, 2017
@veronicagg veronicagg added the bug label Jun 6, 2017
@veronicagg veronicagg added this to the Linter rules wave 5 milestone Jun 6, 2017
@veronicagg veronicagg added the P1 - Required Required functionality - not blocking label Jun 13, 2017
@dsgouda
Copy link
Contributor Author

dsgouda commented Jun 16, 2017

The first dependency, i.e., adding categorizations to each validation rule is done, we still need the rest spec repo to move to the configuration file formats here, post this reorg, we may be able to accurately investigate rules that fail to return proper paths.

@dsgouda dsgouda closed this as completed Jun 16, 2017
@dsgouda dsgouda reopened this Jun 16, 2017
@dsgouda
Copy link
Contributor Author

dsgouda commented Jun 20, 2017

Ran the AutoRest linter with our improvements related to validation categories over the reorg branch
Paths are not found consistently for the following rules and need to be investigated further

  • TrackedResourceListByImmediateParent
  • HttpsSupportedScheme
  • OperationsAPIImplementation
  • GuidUsage

@dsgouda
Copy link
Contributor Author

dsgouda commented Jun 20, 2017

@dsgouda dsgouda closed this as completed Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - Required Required functionality - not blocking
Projects
None yet
Development

No branches or pull requests

2 participants