Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview #10735

Conversation

mrohera
Copy link
Member

@mrohera mrohera commented Sep 9, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 9, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mrohera
Copy link
Member Author

mrohera commented Sep 9, 2020

For the benefit of the reviewers, this preview version was created from the 2020-03-01 (stable) version and the "encryption" CMK properties were added over and above the existing stable API.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-java - Release

failed [Logs] [Expand Details]
  • Generate from 85f2537 with merge commit 28dc9a2. SDK Automation 13.0.17.20200909.5
    [AutoRest] FATAL: System.ArgumentException: An item with the same key has already been added. Key: dpsCertificates
    [AutoRest]    at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
    [AutoRest]    at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
    [AutoRest]    at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
    [AutoRest]    at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.Add(SegmentFluentMethodGroupList list) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 66
    [AutoRest]    at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.InnerMethodGroupToSegmentFluentMethodGroups(CodeModelJvaf codeModel) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 79
    [AutoRest]    at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 55
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
    [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    [AutoRest] FATAL: java/generate - FAILED
    [AutoRest] FATAL: Error: Plugin java reported failure.
    [AutoRest] Failure during batch task - {"tag":"package-2017-08"} -- Error: Plugin java reported failure..
    [AutoRest]   Error: Plugin java reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --version=V2 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@preview --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/deviceprovisioningservices/resource-manager/readme.md FATAL: System.ArgumentException: An item with the same key has already been added. Key: dpsCertificates
       at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
       at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
       at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
       at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.Add(SegmentFluentMethodGroupList list) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 66
       at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.InnerMethodGroupToSegmentFluentMethodGroups(CodeModelJvaf codeModel) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 79
       at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 55
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    FATAL: java/generate - FAILED
    FATAL: Error: Plugin java reported failure.
    Failure during batch task - {"tag":"package-2017-08"} -- Error: Plugin java reported failure..
      Error: Plugin java reported failure.
    , {} 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 85f2537 with merge commit 28dc9a2. SDK Automation 13.0.17.20200909.5
  • ️✔️@azure/arm-deviceprovisioningservices [View full logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/iotDpsClient.js → ./dist/arm-deviceprovisioningservices.js...
    [npmPack] created ./dist/arm-deviceprovisioningservices.js in 390ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-deviceprovisioningservices@2.1.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 102.6kB dist/arm-deviceprovisioningservices.js        
    [npmPack] npm notice 35.7kB  dist/arm-deviceprovisioningservices.min.js    
    [npmPack] npm notice 9.6kB   esm/operations/dpsCertificate.js              
    [npmPack] npm notice 976B    esm/models/dpsCertificateMappers.js           
    [npmPack] npm notice 345B    esm/models/index.js                           
    [npmPack] npm notice 449B    esm/operations/index.js                       
    [npmPack] npm notice 1.5kB   esm/iotDpsClient.js                           
    [npmPack] npm notice 2.5kB   esm/iotDpsClientContext.js                    
    [npmPack] npm notice 31.4kB  esm/operations/iotDpsResource.js              
    [npmPack] npm notice 1.2kB   esm/models/iotDpsResourceMappers.js           
    [npmPack] npm notice 32.7kB  esm/models/mappers.js                         
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                  
    [npmPack] npm notice 457B    esm/models/operationsMappers.js               
    [npmPack] npm notice 5.7kB   esm/models/parameters.js                      
    [npmPack] npm notice 1.0kB   rollup.config.js                              
    [npmPack] npm notice 1.8kB   package.json                                  
    [npmPack] npm notice 457B    tsconfig.json                                 
    [npmPack] npm notice 221.6kB dist/arm-deviceprovisioningservices.js.map    
    [npmPack] npm notice 31.5kB  dist/arm-deviceprovisioningservices.min.js.map
    [npmPack] npm notice 3.8kB   esm/operations/dpsCertificate.d.ts.map        
    [npmPack] npm notice 5.3kB   esm/operations/dpsCertificate.js.map          
    [npmPack] npm notice 445B    esm/models/dpsCertificateMappers.d.ts.map     
    [npmPack] npm notice 458B    esm/models/dpsCertificateMappers.js.map       
    [npmPack] npm notice 15.1kB  esm/models/index.d.ts.map                     
    [npmPack] npm notice 183B    esm/operations/index.d.ts.map                 
    [npmPack] npm notice 126B    esm/models/index.js.map                       
    [npmPack] npm notice 198B    esm/operations/index.js.map                   
    [npmPack] npm notice 661B    esm/iotDpsClient.d.ts.map                     
    [npmPack] npm notice 787B    esm/iotDpsClient.js.map                       
    [npmPack] npm notice 490B    esm/iotDpsClientContext.d.ts.map              
    [npmPack] npm notice 1.4kB   esm/iotDpsClientContext.js.map                
    [npmPack] npm notice 9.2kB   esm/operations/iotDpsResource.d.ts.map        
    [npmPack] npm notice 14.9kB  esm/operations/iotDpsResource.js.map          
    [npmPack] npm notice 563B    esm/models/iotDpsResourceMappers.d.ts.map     
    [npmPack] npm notice 576B    esm/models/iotDpsResourceMappers.js.map       
    [npmPack] npm notice 2.0kB   esm/models/mappers.d.ts.map                   
    [npmPack] npm notice 18.2kB  esm/models/mappers.js.map                     
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map            
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map              
    [npmPack] npm notice 215B    esm/models/operationsMappers.d.ts.map         
    [npmPack] npm notice 228B    esm/models/operationsMappers.js.map           
    [npmPack] npm notice 1.3kB   esm/models/parameters.d.ts.map                
    [npmPack] npm notice 4.2kB   esm/models/parameters.js.map                  
    [npmPack] npm notice 3.2kB   README.md                                     
    [npmPack] npm notice 12.1kB  esm/operations/dpsCertificate.d.ts            
    [npmPack] npm notice 21.3kB  src/operations/dpsCertificate.ts              
    [npmPack] npm notice 666B    esm/models/dpsCertificateMappers.d.ts         
    [npmPack] npm notice 972B    src/models/dpsCertificateMappers.ts           
    [npmPack] npm notice 41.2kB  esm/models/index.d.ts                         
    [npmPack] npm notice 133B    esm/operations/index.d.ts                     
    [npmPack] npm notice 39.3kB  src/models/index.ts                           
    [npmPack] npm notice 417B    src/operations/index.ts                       
    [npmPack] npm notice 978B    esm/iotDpsClient.d.ts                         
    [npmPack] npm notice 1.5kB   src/iotDpsClient.ts                           
    [npmPack] npm notice 760B    esm/iotDpsClientContext.d.ts                  
    [npmPack] npm notice 2.3kB   src/iotDpsClientContext.ts                    
    [npmPack] npm notice 30.6kB  esm/operations/iotDpsResource.d.ts            
    [npmPack] npm notice 55.5kB  src/operations/iotDpsResource.ts              
    [npmPack] npm notice 903B    esm/models/iotDpsResourceMappers.d.ts         
    [npmPack] npm notice 1.2kB   src/models/iotDpsResourceMappers.ts           
    [npmPack] npm notice 2.7kB   esm/models/mappers.d.ts                       
    [npmPack] npm notice 26.0kB  src/models/mappers.ts                         
    [npmPack] npm notice 2.1kB   esm/operations/operations.d.ts                
    [npmPack] npm notice 4.1kB   src/operations/operations.ts                  
    [npmPack] npm notice 147B    esm/models/operationsMappers.d.ts             
    [npmPack] npm notice 421B    src/models/operationsMappers.ts               
    [npmPack] npm notice 1.7kB   esm/models/parameters.d.ts                    
    [npmPack] npm notice 5.7kB   src/models/parameters.ts                      
    [npmPack] npm notice 1.1kB   LICENSE.txt                                   
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-deviceprovisioningservices         
    [npmPack] npm notice version:       2.1.0                                         
    [npmPack] npm notice filename:      azure-arm-deviceprovisioningservices-2.1.0.tgz
    [npmPack] npm notice package size:  89.0 kB                                       
    [npmPack] npm notice unpacked size: 823.3 kB                                      
    [npmPack] npm notice shasum:        d74be200a08521ba93fa821211f747c063a9e635      
    [npmPack] npm notice integrity:     sha512-Te0habiMEXFuQ[...]np4hkDj4S9YXw==      
    [npmPack] npm notice total files:   69                                            
    [npmPack] npm notice 
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 01:26:00 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0404:2668:F9303:22FEEF:5F5AD228","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 85f2537 with merge commit 28dc9a2. SDK Automation 13.0.17.20200909.5
  • ️✔️azure-mgmt-iothubprovisioningservices [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-iothubprovisioningservices
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-iothubprovisioningservices
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 01:26:19 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0542:9877:6BAD70:819EE0:5F5AD23B","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 30.568% size of original (original: 24964 chars, delta: 7631 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model IotDpsPropertiesDescription has a new parameter private_endpoint_connections
    [ChangeLog]   - Model IotDpsPropertiesDescription has a new parameter public_network_access
    [ChangeLog]   - Model IotDpsPropertiesDescription has a new parameter encryption
    [ChangeLog]   - Model IotDpsPropertiesDescription has a new parameter ip_filter_rules
    [ChangeLog]   - Added operation IotDpsResourceOperations.list_private_link_resources
    [ChangeLog]   - Added operation IotDpsResourceOperations.list_private_endpoint_connections
    [ChangeLog]   - Added operation IotDpsResourceOperations.get_private_link_resources
    [ChangeLog]   - Added operation IotDpsResourceOperations.delete_private_endpoint_connection
    [ChangeLog]   - Added operation IotDpsResourceOperations.create_or_update_private_endpoint_connection
    [ChangeLog]   - Added operation IotDpsResourceOperations.get_private_endpoint_connection

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-net - Release

failed [Logs] [Expand Details]
  • Generate from 85f2537 with merge commit 28dc9a2. SDK Automation 13.0.17.20200909.5
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • Microsoft.Azure.Management.DeviceProvisioningServices [View full logs]  [Release SDK Changes]
      Failed to create the package Microsoft.Azure.Management.DeviceProvisioningServices.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=deviceprovisioningservices /v:n /p:SkipTests=true , {} 
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 01:28:09 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0440:13D22:6EF33A:847696:5F5AD2A9","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 9, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 9, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 9, 2020

    azure-resource-manager-schemas - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 85f2537 with merge commit 28dc9a2. Schema Automation 13.0.17.20200909.5
    • ⚠️deviceprovisioningservices [View full logs]  [Release Schema Changes]
        AzureResourceSchema has no registered package commands.
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 01:25:41 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0680:4A21:25C8C4:3EF605:5F5AD215","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @mrohera
      Copy link
      Member Author

      mrohera commented Sep 9, 2020

      @xccc-msft, it appears that the failures in the gates seem unrelated to the changes and I am unsure how to proceed. Can you help with this?

      @xseeseesee
      Copy link
      Contributor

      @xccc-msft, it appears that the failures in the gates seem unrelated to the changes and I am unsure how to proceed. Can you help with this?

      @NullMDR Can you please help? Thanks.

      @PhoenixHe-NV
      Copy link
      Contributor

      The SDK generation failure could be ignored.

      @mrohera
      Copy link
      Member Author

      mrohera commented Sep 10, 2020

      Thanks for approving. How can I merge this PR? I am not authorized to merge.

      @rajeevmv
      Copy link
      Contributor

      Can you add an example on how to use the CMK feature?

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @mrohera
      Copy link
      Member Author

      mrohera commented Sep 10, 2020

      Added sample PTAL.

      Copy link
      Contributor

      @rajeevmv rajeevmv left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      :shipit:

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @chiragg4u
      Copy link
      Contributor

      Thank you for keeping the previous version as first commit for easier find the changes.
      Looked at the changes from the previous version and it looked fine. Will mark ARMSignoff.

      @chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 10, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @mrohera
      Copy link
      Member Author

      mrohera commented Sep 10, 2020

      Thanks @chiragg4u for the sign off! What can I do to merge? All the required gate checkins are met.

      @mrohera
      Copy link
      Member Author

      mrohera commented Sep 10, 2020

      The SDK generation failure could be ignored.

      Hi @NullMDR , based on your comment above and since I have ARMSignedOff and all the required checks met, can this PR be merged. I cannot merge this since I am not authorized.

      @PhoenixHe-NV PhoenixHe-NV merged commit 28dc9a2 into Azure:master Sep 11, 2020
      nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
      …zure#10735)
      
      * Adds base for updating Microsoft.Devices from version stable/2020-03-01 to version 2020-09-01-preview
      
      * Updates readme
      
      * Updates API version in new specs and examples
      
      * Add CMK encryption properties
      
      * Add sample for CMK
      
      * Prettier format
      
      * Add example reference
      
      * Add encryption to response in example
      
      * Removing example for now since this is still WIP
      iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
      …into formrecognizer_regeneration
      
      * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits)
        Changes for new api version sdk generate (Azure#10685)
        Update batch sdk comments (Azure#10517)
        Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673)
        Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762)
        Spark Compute Isolation enabled (Azure#10726)
        [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677)
        PostgreSQL Flexible Server New API Swagger Changes (Azure#10586)
        Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760)
        Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752)
        modify description of properties to be self consistent (Azure#10711)
        Adding ComputeInstance to preview swagger (Azure#10654)
        remove unsupported reversproxy and useTestExtension (Azure#10728)
        Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735)
        FR v2.1-preview.1 update (Azure#10747)
        ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071)
        Eventhub: Added PrivateEndpointConnection API (Azure#10635)
        codegen onboard df for cli (Azure#8531)
        Update swagger for outbound public ip feature (Azure#10713)
        2020-09-01-hybrid profile for AzureStack (Azure#10295)
        Update pull_request_assignment.yml (Azure#10724)
        ...
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      5 participants