-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview #10735
Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview #10735
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
For the benefit of the reviewers, this preview version was created from the 2020-03-01 (stable) version and the "encryption" CMK properties were added over and above the existing stable API. |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
@xccc-msft, it appears that the failures in the gates seem unrelated to the changes and I am unsure how to proceed. Can you help with this? |
@NullMDR Can you please help? Thanks. |
The SDK generation failure could be ignored. |
Thanks for approving. How can I merge this PR? I am not authorized to merge. |
Can you add an example on how to use the CMK feature? |
Azure Pipelines successfully started running 1 pipeline(s). |
Added sample PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Thank you for keeping the previous version as first commit for easier find the changes. |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks @chiragg4u for the sign off! What can I do to merge? All the required gate checkins are met. |
Hi @NullMDR , based on your comment above and since I have ARMSignedOff and all the required checks met, can this PR be merged. I cannot merge this since I am not authorized. |
…zure#10735) * Adds base for updating Microsoft.Devices from version stable/2020-03-01 to version 2020-09-01-preview * Updates readme * Updates API version in new specs and examples * Add CMK encryption properties * Add sample for CMK * Prettier format * Add example reference * Add encryption to response in example * Removing example for now since this is still WIP
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits) Changes for new api version sdk generate (Azure#10685) Update batch sdk comments (Azure#10517) Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673) Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762) Spark Compute Isolation enabled (Azure#10726) [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677) PostgreSQL Flexible Server New API Swagger Changes (Azure#10586) Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760) Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752) modify description of properties to be self consistent (Azure#10711) Adding ComputeInstance to preview swagger (Azure#10654) remove unsupported reversproxy and useTestExtension (Azure#10728) Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735) FR v2.1-preview.1 update (Azure#10747) ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071) Eventhub: Added PrivateEndpointConnection API (Azure#10635) codegen onboard df for cli (Azure#8531) Update swagger for outbound public ip feature (Azure#10713) 2020-09-01-hybrid profile for AzureStack (Azure#10295) Update pull_request_assignment.yml (Azure#10724) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.