-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swagger for outbound public ip feature #10713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Sep 7, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
This was referenced Sep 7, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
njuCZ
approved these changes
Sep 9, 2020
njuCZ
added
DoNotMerge
<valid label in PR review process> use to hold merge after approval
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
DoNotMerge
<valid label in PR review process> use to hold merge after approval
labels
Sep 9, 2020
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
* update swagger for outbound public ip feature * Update samples * prettier all the files * fix typo for 'outboundIPs' & 'publicIPs' properties Co-authored-by: Xuyang Cao <xuycao@microsoft.com>
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 14, 2020
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits) Changes for new api version sdk generate (Azure#10685) Update batch sdk comments (Azure#10517) Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673) Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762) Spark Compute Isolation enabled (Azure#10726) [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677) PostgreSQL Flexible Server New API Swagger Changes (Azure#10586) Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760) Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752) modify description of properties to be self consistent (Azure#10711) Adding ComputeInstance to preview swagger (Azure#10654) remove unsupported reversproxy and useTestExtension (Azure#10728) Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735) FR v2.1-preview.1 update (Azure#10747) ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071) Eventhub: Added PrivateEndpointConnection API (Azure#10635) codegen onboard df for cli (Azure#8531) Update swagger for outbound public ip feature (Azure#10713) 2020-09-01-hybrid profile for AzureStack (Azure#10295) Update pull_request_assignment.yml (Azure#10724) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.