Update build and sign pipeline of Az.Tools.Predictor #17768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kceiw
previously approved these changes
Apr 11, 2022
| @@ -41,8 +41,10 @@ For more information on Az Predictor, please visit the following: https://aka.ms | |||
| PowerShellVersion = '7.2' | |||
|
|
|||
| # Modules that must be imported into the global environment prior to importing this module | |||
| # "RequiredModules" requires the module in the build pipeline to build/sign this package. Instead, we will validate the dependencies at runtime by Az.Tools.Predictor.psm1 | |||
| RequiredModules = @(@{ModuleName = 'PSReadLine'; ModuleVersion = '2.2.2'; }, | |||
| @{ModuleName = 'Az.Accounts'; ModuleVersion = '2.7.5';}) | |||
There was a problem hiding this comment.
Is dependency on Az.Accounts needed? Az.ToolsPredictor doesn't use anything directly from Az.Accounts.
There was a problem hiding this comment.
It needs share assembly imported by Az.Accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added