Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use msbuild to build Az.Tools.Predictor.sln #17727

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

kceiw
Copy link
Contributor

@kceiw kceiw commented Apr 6, 2022

Description

dotnet msbuild is used in the pipeline to build the solution Az.Tools.Predictor.sln. That doesn't work with the workaround about transient dependencies on the source generator project. The workaround that work with dotnet msbuild doesn't work with msbuild either. See the issue here dotnet/sdk#17775. So in this change, I use mbuild to build the solution. That should make the build the same in the pipeline, command line on dev machine and Visual Studio on the dev machine.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@kceiw kceiw requested a review from dingmeng-xue April 6, 2022 17:36
@dingmeng-xue dingmeng-xue self-assigned this Apr 7, 2022
@dingmeng-xue dingmeng-xue changed the base branch from main to internal/predictor April 7, 2022 13:13
@dingmeng-xue dingmeng-xue merged commit 1a20690 into Azure:internal/predictor Apr 7, 2022
dingmeng-xue added a commit that referenced this pull request Apr 14, 2022
Force merge code because of unrelated error in Az.Accounts

* Use msbuild to build Az.Tools.Predictor.sln (#17727)

* Update build and sign pipeline of Az.Tools.Predictor

* Update code

* update code

* Update version of az.accounts

* update

* Update code

Co-authored-by: kceiw <mahuang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants