-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aspire: Fix panic when a project has no endpoints #4065
Conversation
Worker projects do not expose endpoints and hence do not need ingress configured on their container apps. We had a bug in constructing the template context in the case where a project did not have and endpoints. To address this, we only set `TargetPortExpression` in the case where we have Ingress configured. `TargetPortExpression` is only used in the template when the service has ingress, so the empty value will cause no harm in cases where the service has not configured ingress. Fixes Azure#4064
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
CI is having trouble for centOS:
This is not related to this fix, so I will override CI and consider this as a pass |
/check-enforcer override |
* aspire: Fix panic when a project has no endpoints Worker projects do not expose endpoints and hence do not need ingress configured on their container apps. We had a bug in constructing the template context in the case where a project did not have and endpoints. To address this, we only set `TargetPortExpression` in the case where we have Ingress configured. `TargetPortExpression` is only used in the template when the service has ingress, so the empty value will cause no harm in cases where the service has not configured ingress. Fixes #4064
Worker projects do not expose endpoints and hence do not need ingress configured on their container apps. We had a bug in constructing the template context in the case where a project did not have and endpoints.
To address this, we only set
TargetPortExpression
in the case where we have Ingress configured.TargetPortExpression
is only used in the template when the service has ingress, so the empty value will cause no harm in cases where the service has not configured ingress.Fixes #4064