-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Admin Access from Aspire - ACR #4149
Conversation
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Do you know if the service team fixed the underlying issue that caused us to turn this on? IIRC there was an issue with old accounts (created before Azure RBAC which were not Owner) being able to get the credentials they needed. IIRC I was able to reproduce this with my personal MSA back when we understood what was going on and I can test this if you are unsure. |
The issue is still open: Azure/acr#723 So, if you have some time to validate, @ellismg , it would be awesome. And @rajeshkamal5050 suggestion is to use docs to tell anyone impacted how to mitigate: #4147 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I logged in using my personal MSA (which was old enough to have exhibited the issue that we added this as a workaround for) and things just worked, even with these changes, so it does seem like the underlying service fix addressed our end to end.
Thanks for making our customers more secure by default, @vhvb1989!
fix: #4147