-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] rename admin k8s context so it won't overwite user context #6529
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6529 +/- ##
===================================
Coverage 0% 0%
===================================
Files 11 11
Lines 133 133
Branches 9 9
===================================
Misses 133 133 Continue to review full report at Codecov.
|
Given #6497 I assume I'll have to update HISTORY.rst in this PR before it can be merged. |
admin_name = ctx['name'] + '-admin' | ||
addition['current-context'] = ctx['name'] = admin_name | ||
break | ||
except (KeyError, TypeError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the try catch in the loop instead of out of the loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed.
9ee9439
to
a463c37
Compare
Rebased to fix merge conflict. |
Ok. I'll merge it now. |
Fixes an issue where
az aks get-credentials
didn't distinguish between the admin and user versions when merging into ~/.kube/config.Before:
After:
cc: @slack
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.