[AKS] update to v20180331 API and add new feature args #6497
Conversation
Codecov Report
@@ Coverage Diff @@
## rc38 #6497 +/- ##
====================================
Coverage 0% 0%
====================================
Files 11 11
Lines 133 133
Branches 9 9
====================================
Misses 133 133Continue to review full report at Codecov.
|
|
@mboersma I will put up a do not merge label per the private build. When will the private package be online? |
I'm not sure yet. Azure/azure-sdk-for-python#2186 is ready to go and I'm asking around to get it published. Edit: available now. |
| @@ -3,6 +3,14 @@ | |||
| Release History | |||
| =============== | |||
|
|
|||
| 2.0.35 | |||
There was a problem hiding this comment.
I think the version should be bumped to 2.1.0 as it is GA now?
| @@ -14,7 +14,7 @@ | |||
| logger.warn("Wheel is not available, disabling bdist_wheel hook") | |||
| cmdclass = {} | |||
|
|
|||
| VERSION = "2.0.34" | |||
| VERSION = "2.0.35" | |||
| if 'http_application_routing' in addons: | ||
| addon_profiles['httpApplicationRouting'] = ManagedClusterAddonProfile(enabled=True) | ||
| addons.remove('http_application_routing') | ||
| # TODO: can we help the user find a workspace resource ID? |
There was a problem hiding this comment.
Opening an issue to track instead of in code TODO?
There was a problem hiding this comment.
We are already tracking this improvement in VSTS and plan to have it implemented for the subsequent CLI release. I can remove the # TDOO: if you prefer but there are several others in this file too.
|
@troydai the .whl is published to pypi and I removed the temp commit. Let me know what other changes you would like to see. |
|
Looks good to me. I'll merge it now. |
Uses the new v20180331 AKS API and adds arguments to support new AKS GA and preview features: RBAC, VNet customization ("advanced networking"), no SSH key needed, Log Analytics monitoring, HTTP application routing, and Azure AD integration (in preview).
Note that this still includes a temp commit with a private copy of the azure-mgmt-containerservice .whl. I'll need to remove that when it is published to Pypi, before this PR merges.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.