interpret the '@' syntax if something higher hasn't already done that. #1423
Conversation
|
@brendandburns, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yugangw-msft, @tjprescott and @derekbekoe to be potential reviewers. |
|
@brendandburns this issue applies more generally to the CLI. See issue #1419. I think it can fixed more generally by making a change here: https://github.com/Azure/azure-cli/blob/master/src/azure-cli-core/azure/cli/core/application.py#L200 In addition to startswith('@') we can probably have something like |
|
Can we not make use of this? |
brendandburns
force-pushed
the
read-file
branch
from
09b4968 to
958cf4c
Compare
|
@tjprescott thanks for the tip, I moved the code to that location (and I added unit tests too as a bonus!) please take another look. Thanks! |
brendandburns
force-pushed
the
read-file
branch
2 times, most recently
from
5676ee3 to
d210bfb
Compare
This problem is that with |
| if ix == -1: | ||
| return arg | ||
| # TODO: this is kind of imperfect, use a regexp here? | ||
| if ix != 0 and arg[ix - 1] != '=': |
There was a problem hiding this comment.
So in the original issue, the poster reported using ="@..." so we would also need to check for that (or use a regex).
brendandburns
force-pushed
the
read-file
branch
from
d210bfb to
20defba
Compare
|
@tjprescott fixed (and added tests to cover it) please take another look. Thanks |
|
Awesome! Thank you @brendandburns ! |
* Azure/master: (39 commits) User should use no-cache so we build a fresh image (Azure#1455) Bump all modules to version 0.1.0b10 (Azure#1454) [Docs] Move around the order of install instructions. (Azure#1439) acs: *_install_cli mark cli as executable (Azure#1449) Fix resource list table. (Azure#1452) [Compute] VM NIC updates (Azure#1421) Introduce batch upload and download for blob (Azure#1428) Add auto-registration for resource providers. (Azure#1330) interpret the '@' syntax if something higher hasn't already done that. (Azure#1423) Aliasing plan argument with shorthand (Azure#1433) ad:fix one more place which still uses localtime for secret starttime (Azure#1429) Add table formatting for deployments and sort by timestmap. (Azure#1427) Add table formatting for resource group list (and add 'status') (Azure#1425) [Docs] Add shields specifying latest version and supported python versions (Azure#1420) Add new az storage blob copy start-batch command (Azure#1250) Component Discovery (Azure#1409) Add poison logic to prevent re-recording tests that need updating. (Azure#1412) [Storage] Fix storage table outputs and help text. (Azure#1402) [mention-bot] Attempt to fix config (Azure#1410) ad:use utc time on setting app's creds (Azure#1408) ...
Fixes #1379
Fixes #1419
@jmspring @yugang-msft