[Storage] Fix storage table outputs and help text. #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjprescott, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JasonRShaver, @derekbekoe and @BurtBiel to be potential reviewers. |
derekbekoe
reviewed
Nov 22, 2016
| new_entry['Name'] = item_name | ||
| new_entry['Content Length'] = ' ' if is_dir else item['properties']['contentLength'] | ||
| new_entry['Type'] = 'dir' if is_dir else 'file' | ||
| new_entry['Last Modified'] = item['properties']['lastModified'] or ' ' |
There was a problem hiding this comment.
Will item['properties']['lastModified'] always exist?
Or is this check to see if item['properties']['lastModified'] is False, empty etc.?
Otherwise, you may get a KeyError.
There was a problem hiding this comment.
If lastModified is null, then what happens is the table just leaves that column off. The or ' ' ensures that it at least has a space so you will get a blank "cell". Otherwise your table dynamic when it really isn't.
derekbekoe
approved these changes
Nov 22, 2016
thegalah
pushed a commit
to thegalah/azure-cli
that referenced
this pull request
Nov 28, 2016
* Azure/master: (39 commits) User should use no-cache so we build a fresh image (Azure#1455) Bump all modules to version 0.1.0b10 (Azure#1454) [Docs] Move around the order of install instructions. (Azure#1439) acs: *_install_cli mark cli as executable (Azure#1449) Fix resource list table. (Azure#1452) [Compute] VM NIC updates (Azure#1421) Introduce batch upload and download for blob (Azure#1428) Add auto-registration for resource providers. (Azure#1330) interpret the '@' syntax if something higher hasn't already done that. (Azure#1423) Aliasing plan argument with shorthand (Azure#1433) ad:fix one more place which still uses localtime for secret starttime (Azure#1429) Add table formatting for deployments and sort by timestmap. (Azure#1427) Add table formatting for resource group list (and add 'status') (Azure#1425) [Docs] Add shields specifying latest version and supported python versions (Azure#1420) Add new az storage blob copy start-batch command (Azure#1250) Component Discovery (Azure#1409) Add poison logic to prevent re-recording tests that need updating. (Azure#1412) [Storage] Fix storage table outputs and help text. (Azure#1402) [mention-bot] Attempt to fix config (Azure#1410) ad:use utc time on setting app's creds (Azure#1408) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1066, fixes #1003, fixes #1002, fixes #1266.
Creates custom callables for various table output formats in storage. Updates help text.