Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AzContainerApp} fixes Azure/azure-cli-extensions#5067 #5085

Merged
merged 5 commits into from
Jul 11, 2022
Merged

{AzContainerApp} fixes Azure/azure-cli-extensions#5067 #5085

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98e5d8a
{AzContainerApp} fixes Azure/azure-cli-extensions#5067
navba-MSFT Jul 6, 2022
8f0ebeb
Update custom.py
navba-MSFT Jul 6, 2022
6411b93
{AzContainerApp} fixes Azure/azure-cli-extensions#5067
navba-MSFT Jul 11, 2022
46aa677
Update src/containerapp/azext_containerapp/custom.py
navba-MSFT Jul 11, 2022
7cd851a
{AzContainerApp} fixes Azure/azure-cli-extensions#5067
navba-MSFT Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/containerapp/azext_containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,11 @@ def update_containerapp_logic(cmd,
from_revision=None):
_validate_subscription_registered(cmd, CONTAINER_APPS_RP)

# Validate that max_replicas is set to 0-30
if max_replicas is not None:
if max_replicas < 1 or max_replicas > 30:
raise ArgumentUsageError('--max-replicas must be in the range [1,30]')

if yaml:
if image or min_replicas or max_replicas or\
set_env_vars or remove_env_vars or replace_env_vars or remove_all_env_vars or cpu or memory or\
Expand Down