{AzContainerApp} fixes Azure/azure-cli-extensions#5067 #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
az containerapp update -n ContainerAppName -g ResourceGroup --min-replicas 0 --max-replicas 0 finishes without throwing any error, however scaling configuration is not updated as max replicas cannot be zero. This PR should include a fix to validate the --max-replicas field while the value is sent as Zero and raise CLIError
navba-MSFT
requested review from
calvinsID,
runefa and
panchagnula
as code owners
ghost
requested a review
from 
ghost
added
the
|
AzContainerApp |
zhoxing-ms
reviewed
Jul 11, 2022
Please solve the flake8 issue |
used the specific error type ArgumentUsageError instead of CLIError az containerapp update -n ContainerAppName -g ResourceGroup --min-replicas 0 --max-replicas 0 finishes without throwing any error, however scaling configuration is not updated as max replicas cannot be zero. This PR should include a fix to validate the --max-replicas field while the value is sent as Zero and raise CLIError fixes Azure#5067
zhoxing-ms
reviewed
Jul 11, 2022
updated Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
az containerapp update -n ContainerAppName -g ResourceGroup --min-replicas 0 --max-replicas 0 finishes without throwing any error, however scaling configuration is not updated as max replicas cannot be zero. This PR should include a fix to validate the --max-replicas field while the value is sent as Zero and raise CLIError fixes Azure#5067
zhoxing-ms
approved these changes
Jul 11, 2022
navba-MSFT
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
az containerapp update -n ContainerAppName -g ResourceGroup --min-replicas 0 --max-replicas 0 finishes without throwing any error, however scaling configuration is not updated as max replicas cannot be zero.
This PR should include a fix to validate the --max-replicas field while the value is sent as Zero and raise CLIError
fixes #5067
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.