Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add templating and custom config file to complete #89

Merged
merged 10 commits into from
Jan 19, 2024

Conversation

luke-taylor
Copy link
Contributor

@luke-taylor luke-taylor commented Jan 14, 2024

Overview/Summary

This PR introduces templating for the config file of the complete module. It also introduces the specific config file parameter.

This PR has a dependency on: Azure/ALZ-PowerShell-Module#100

This PR fixes/adds/changes/removes

  1. Feature Request: complete module config updates #85

Breaking Changes

additional_files has been changed to a hidden input, so users will no longer be prompted fore this.

Testing Evidence

Will trigger e2e tests.

Ran an end to end test locally and here is the successful plan run with a custom config file, also tested with an empyy value for the config file and confirms it defaults to the config.yaml file as expected:
image

image

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-requested a review January 18, 2024 17:35
@jaredfholgate jaredfholgate self-assigned this Jan 18, 2024
@jaredfholgate jaredfholgate added the enhancement New feature or request label Jan 18, 2024
@jaredfholgate jaredfholgate changed the title feat: add templating to complete feat: add templating and custom config file to complete Jan 18, 2024
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Jan 18, 2024
@jaredfholgate
Copy link
Member

NOTE: Tests won't pass until Azure/ALZ-PowerShell-Module#100 is released. Will re-run once that is live.

Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@jaredfholgate jaredfholgate merged commit 8de020a into main Jan 19, 2024
22 checks passed
@jaredfholgate jaredfholgate deleted the feat/temp-complete branch January 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: Safe to test 🧪 Enables running of End to End Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants