-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add templating and custom config file to complete
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredfholgate
changed the title
feat: add templating to
feat: add templating and custom config file to Jan 18, 2024
complete
complete
NOTE: Tests won't pass until Azure/ALZ-PowerShell-Module#100 is released. Will re-run once that is live. |
jaredfholgate
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. :)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR introduces templating for the config file of the complete module. It also introduces the specific config file parameter.
This PR has a dependency on: Azure/ALZ-PowerShell-Module#100
This PR fixes/adds/changes/removes
complete
module config updates #85Breaking Changes
additional_files
has been changed to a hidden input, so users will no longer be prompted fore this.Testing Evidence
Will trigger e2e tests.
Ran an end to end test locally and here is the successful plan run with a custom config file, also tested with an empyy value for the config file and confirms it defaults to the
config.yaml
file as expected:As part of this Pull Request I have
main
branch