Add config file specific code #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jaredfholgate
added a commit
to Azure/alz-terraform-accelerator
that referenced
this pull request
Jan 19, 2024
<!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary This PR introduces templating for the config file of the complete module. It also introduces the specific config file parameter. This PR has a dependency on: Azure/ALZ-PowerShell-Module#100 ## This PR fixes/adds/changes/removes 1. #85 ### Breaking Changes `additional_files` has been changed to a hidden input, so users will no longer be prompted fore this. ## Testing Evidence Will trigger e2e tests. Ran an end to end test locally and here is the successful plan run with a custom config file, also tested with an empyy value for the config file and confirms it defaults to the `config.yaml` file as expected:    ## As part of this Pull Request I have - [x] Checked for duplicate [Pull Requests](https://github.com/Azure/alz-terraform-accelerator/pulls) - [x] Associated it with relevant [issues](https://github.com/Azure/alz-terraform-accelerator/issues), for tracking and closure. - [x] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/alz-terraform-accelerator/tree/main) - [x] Performed testing and provided evidence. - [x] Updated relevant and associated documentation. --------- Co-authored-by: Jared Holgate <jaredholgate@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Issue #, if available: N/A
Description
Description of changes:
This PR adds the ability to pass a config file path that is then included in the repository. This is to be more concise for users of the accelerator and only prompt for a config file if they are using a starter module that needs one. Also enables them to call the config file whatever name they desire.
This change has been tested and testing evidence can be found in the sister PR here: Azure/alz-terraform-accelerator#89
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.