One thread for telemetry

azurelinuxagent/common/cgroupapi.py

@@ -385,7 +385,6 @@ def start_extension_command(self, extension_name, command, timeout, shell, cwd,
         :param stderr: File object to redirect stderr to
         :param error_code: Extension error code to raise in case of error
         """
-        # pylint: disable=too-many-locals
         try:
             extension_cgroups = self.create_extension_cgroups(extension_name)
         except Exception as exception:
@@ -577,7 +576,7 @@ def create_extension_cgroups_root(self):
         logger.info("Created slice for walinuxagent extensions {0}".format(unit_filename))
 
     def create_extension_cgroups(self, extension_name):
-        # TODO: The slice created by this function is not used currently. We need to create the extension scopes within # pylint: disable=W0511
+        # TODO: The slice created by this function is not used currently. We need to create the extension scopes within
         #  this slice and use the slice to monitor the cgroups. Also see comment in get_extension_cgroups.
         # the slice.
         unit_contents = """
@@ -611,7 +610,7 @@ def remove_extension_cgroups(self, extension_name):
             raise CGroupsException("Failed to remove {0}. Error: {1}".format(unit_filename, ustr(e)))
 
     def get_extension_cgroups(self, extension_name):
-        # TODO: The slice returned by this function is not used currently. We need to create the extension scopes within # pylint: disable=W0511
+        # TODO: The slice returned by this function is not used currently. We need to create the extension scopes within
         #  this slice and use the slice to monitor the cgroups. Also see comment in create_extension_cgroups.
         slice_name = self._get_extension_cgroup_name(extension_name)
 
@@ -661,7 +660,7 @@ def _is_systemd_failure(scope_name, stderr):
         unit_not_found = "Unit {0} not found.".format(scope_name)
         return unit_not_found in stderr or scope_name not in stderr
 
-    def start_extension_command(self, extension_name, command, timeout, shell, cwd, env, stdout, stderr, # pylint: disable=R0913,R0914
+    def start_extension_command(self, extension_name, command, timeout, shell, cwd, env, stdout, stderr, # pylint: disable=R0913
                                 error_code=ExtensionErrorCodes.PluginUnknownFailure):
         scope = "{0}_{1}".format(self._get_extension_cgroup_name(extension_name), uuid.uuid4())
 

azurelinuxagent/common/cgroupconfigurator.py

@@ -50,7 +50,6 @@ def __init__(self):
 
         # too-many-branches<R0912> Disabled: branches are sequential, not nested
         def initialize(self):  # pylint: disable=R0912
-            # pylint: disable=too-many-locals
             try:
                 if self._initialized:
                     return

azurelinuxagent/common/dhcp.py

@@ -14,23 +14,23 @@
 #
 # Requires Python 2.6+ and Openssl 1.0+
 
+import array
 import os
 import socket
-import array
 import time
+
 import azurelinuxagent.common.logger as logger
+from azurelinuxagent.common.exception import DhcpError
+from azurelinuxagent.common.osutil import get_osutil
+from azurelinuxagent.common.utils.restutil import KNOWN_WIRESERVER_IP
 from azurelinuxagent.common.utils.textutil import hex_dump, hex_dump2, \
     hex_dump3, \
     compare_bytes, str_to_ord, \
     unpack_big_endian, \
     int_to_ip4_addr
-from azurelinuxagent.common.exception import DhcpError
-from azurelinuxagent.common.osutil import get_osutil
-
 
 # the kernel routing table representation of 168.63.129.16
 KNOWN_WIRESERVER_IP_ENTRY = '10813FA8'
-from azurelinuxagent.common.utils.restutil import KNOWN_WIRESERVER_IP # pylint: disable=C0413
 
 
 def get_dhcp_handler():
@@ -100,7 +100,7 @@ def wireserver_route_exists(self):
             logger.error(
                 "Could not determine whether route exists to {0}: {1}".format(
                     KNOWN_WIRESERVER_IP, e))
-                    
+
         return route_exists
 
     @property
@@ -162,9 +162,9 @@ def send_dhcp_req(self):
         Build dhcp request with mac addr
         Configure route to allow dhcp traffic
         Stop dhcp service if necessary
-        """ 
+        """
         # pylint: enable=W0105
-        
+
         logger.info("Send dhcp request")
         mac_addr = self.osutil.get_mac_addr()
 
@@ -389,7 +389,7 @@ def build_dhcp_request(mac_addr, request_broadcast):
         # set broadcast flag to true to request the dhcp server
         # to respond to a boradcast address,
         # this is useful when user dhclient fails.
-        request[0x0A] = 0x80; # pylint: disable=W0301
+        request[0x0A] = 0x80
 
     # fill in ClientHardwareAddress
     for a in range(0, 6): # pylint: disable=C0103

azurelinuxagent/common/event.py

@@ -523,7 +523,6 @@ def add_metric(self, category, counter, instance, value, log_event=False): # pyl
         :param bool log_event: If true, log the collected metric in the agent log
         """
         if log_event:
-            from azurelinuxagent.common.version import AGENT_NAME # pylint: disable=W0404,W0621
             message = "Metric {0}/{1} [{2}] = {3}".format(category, counter, instance, value)
             _log_event(AGENT_NAME, "METRIC", message, 0)
 
@@ -621,7 +620,6 @@ def elapsed_milliseconds(utc_start):
 
 
 def report_event(op, is_success=True, message='', log_event=True): # pylint: disable=C0103
-    from azurelinuxagent.common.version import AGENT_NAME, CURRENT_VERSION # pylint: disable=W0404,W0621
     add_event(AGENT_NAME,
               version=str(CURRENT_VERSION),
               is_success=is_success,
@@ -631,7 +629,6 @@ def report_event(op, is_success=True, message='', log_event=True): # pylint: dis
 
 
 def report_periodic(delta, op, is_success=True, message=''): # pylint: disable=C0103
-    from azurelinuxagent.common.version import AGENT_NAME, CURRENT_VERSION # pylint: disable=W0404,W0621
     add_periodic(delta, AGENT_NAME,
                  version=str(CURRENT_VERSION),
                  is_success=is_success,
@@ -650,7 +647,6 @@ def report_metric(category, counter, instance, value, log_event=False, reporter=
     :param EventLogger reporter: The EventLogger instance to which metric events should be sent
     """
     if reporter.event_dir is None:
-        from azurelinuxagent.common.version import AGENT_NAME # pylint: disable=W0404,W0621
         logger.warn("Cannot report metric event -- Event reporter is not initialized.")
         message = "Metric {0}/{1} [{2}] = {3}".format(category, counter, instance, value)
         _log_event(AGENT_NAME, "METRIC", message, 0)

azurelinuxagent/common/future.py

@@ -33,12 +33,12 @@
     # unused-import<W0611>, import-error<E0401> Disabled: Due to backward compatibility between py2 and py3
     from builtins import int, range # pylint: disable=unused-import,import-error
     from collections import OrderedDict # pylint: disable=W0611
-    from queue import Queue, Full # pylint: disable=W0611,import-error
+    from queue import Queue, Empty # pylint: disable=W0611,import-error
 
 elif sys.version_info[0] == 2:
     import httplib as httpclient # pylint: disable=E0401,W0611
     from urlparse import urlparse # pylint: disable=E0401
-    from Queue import Queue, Full # pylint: disable=W0611,import-error
+    from Queue import Queue, Empty # pylint: disable=W0611,import-error
 
 
     # We want to suppress the following:

azurelinuxagent/common/logger.py

@@ -145,7 +145,7 @@ def write_log(log_appender): # pylint: disable=W0612
         for appender in self.appenders:
             appender.write(level, log_item)
             #
-            # TODO: we should actually call # pylint: disable=W0511
+            # TODO: we should actually call
             #
             #     write_log(appender)
             #
@@ -158,7 +158,7 @@ def write_log(log_appender): # pylint: disable=W0612
             for appender in self.logger.appenders:
                 appender.write(level, log_item)
                 #
-                # TODO: call write_log instead (see comment above) # pylint: disable=W0511
+                # TODO: call write_log instead (see comment above)
                 #
 
     def add_appender(self, appender_type, level, path):

azurelinuxagent/common/osutil/default.py

@@ -791,7 +791,7 @@ def get_first_if(self):
         return '', ''
 
     @staticmethod
-    def _build_route_list(proc_net_route): # pylint: disable=R0914
+    def _build_route_list(proc_net_route):
         """
         Construct a list of network route entries
         :param list(str) proc_net_route: Route table lines, including headers, containing at least one route
@@ -939,7 +939,7 @@ def get_dhcp_lease_endpoint(self):
         return None
 
     @staticmethod
-    def get_endpoint_from_leases_path(pathglob): # pylint: disable=R0912,R0914
+    def get_endpoint_from_leases_path(pathglob): # pylint: disable=R0912
         """
         Try to discover and decode the wireserver endpoint in the
         specified dhcp leases path.