One thread for telemetry #2019

larohra · 2020-09-23T21:30:29Z

Description

This PR mainly converges sending telemetry out from a single thread instead of multiple threads sending them out separately (Monitor thread and Extension Telemetry thread).

Main changes in the PR -

Send telemetry from one single thread
Move collection of telemetry events to one thread (unify extension telemetry thread and agent extension event collector from monitor thread)

Apart from the major changes, there are some code refactoring, minor bug fixes and linter fixes included in this PR.

Issue #

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes in the description.
New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

I have read the contribution guidelines.

…elemetry # Conflicts: # azurelinuxagent/ga/extension_telemetry.py # azurelinuxagent/ga/monitor.py # tests/common/test_event.py

larohra · 2020-10-29T17:17:52Z

Green DCR run (except for 1 known setup failure) - https://tuxgold.corp.microsoft.com/job/AzLinux/job/DungeonCrawler/job/DungeonCrawler.larohra3/168/

azurelinuxagent/ga/send_telemetry_events.py

azurelinuxagent/ga/collect_telemetry_events.py

pgombar

Some comments and suggestions around improving the clarity of some parts of the code. Also synced offline on PEP8 style conventions for whitespace (less important).

…elemetry

larohra · 2020-11-04T23:33:57Z

Green DCR run (except for the known agent-slb issue) - https://tuxgold.corp.microsoft.com/job/AzLinux/job/DungeonCrawler/job/DungeonCrawler.larohra3/169/

larohra added 30 commits September 11, 2020 11:45

Added a new thread for sending telemetry data

04b4bb4

Added a new priority queue for sending events

97bc0b6

Added stacktrace for failure

10added

Added stacktrace for failures and made it a set

647bbaf

Added a counter to pq to avoid collisions and more logging

2896b23

Changed logging to verbose

a9e7beb

Added a global counter for PQ

540f5f1

Added more logging

b21f97c

Fixed faulty condition

c00b28d

Implemented comparator for TelemetryEvent class

3b7b393

Moved class

859843c

Code fix and more logging

76f1290

Removed dead code

e0eb752

Made ETP code compatible with new telemetry service

d45d73e

Added more debug data

b55c8e5

More logging

1b4a240

bug fix

27d5ca8

Improved logging

b019840

Fixed some failing tests

b8a7248

Hijacking verbose flag for testing

38c4e86

Refactored and fixed ETP and ETP tests

7f9a723

Added queue.join for telemetry_service

b2b33a0

Added tests for the telemetry_service

a072f3d

Fixed some tests and code

de7d744

Fixed final failing tests

318f7a1

Fixed linter errors

16561fe

Fixed linter errors - pt2

8c7207b

Fixed failing py3 test

98e8c3a

Merge remote-tracking branch 'upstream/develop' into one-thread-for-t…

b6b3f07

…elemetry # Conflicts: # azurelinuxagent/ga/extension_telemetry.py # azurelinuxagent/ga/monitor.py # tests/common/test_event.py

Added thread interface to Telemetry service and minor bug fixes

ea94628

Updated changes and removed dead linter errors

7e8a223

Merge branch 'develop' into one-thread-for-telemetry

498358c

narrieta reviewed Oct 29, 2020

View reviewed changes

azurelinuxagent/ga/send_telemetry_events.py Outdated Show resolved Hide resolved

narrieta reviewed Oct 29, 2020

View reviewed changes

azurelinuxagent/ga/send_telemetry_events.py Show resolved Hide resolved

Addressed PR comments

8f61933

narrieta previously approved these changes Oct 29, 2020

View reviewed changes