Send events when extensions fail to complete operation #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
requested review from
boumenot,
hglkrijger,
jasonzio,
narrieta and
roiyz-msft
narrieta
approved these changes
Nov 15, 2018
|
The intention behind the "is_triggered" thing is to avoid flooding the logs when things go bad. The idea was for the event to start out "triggered" and be "reset" the first time it's seen; periodically, all events were reset (in some other thread) to "triggered". If the initial state is erroneously set (i.e. to the "reset" state) or if the periodic reset (a) never happens or (b) actually sets the trigger state incorrectly, then that's the bug. |
vrdmr
force-pushed
the
vameru-send-failure-telemetry
branch
4 times, most recently
from
5ead736
to
49da85e
Compare
vrdmr
force-pushed
the
vameru-send-failure-telemetry
branch
from
49da85e
to
05e6b75
Compare
vrdmr
added a commit
that referenced
this pull request
Nov 19, 2018
* Changed local variable name and added traceback for exthandler failures (#1392) * Changed local variable name and added traceback * Changing the traceback location * Fix the threshold telemetry issue (#1394) * Adding the get_limits call within the collect_all_tracked call * Added tests for threshold * Send events when extensions fail to complete operation (#1397) * Bumping up the version to 2.2.34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #1396
PR information
Quality of Code and Contribution Guidelines