Fix the threshold telemetry issue #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonzio
requested changes
Nov 13, 2018
There was a problem hiding this comment.
This isn't the right way to fix this problem. Move computation of thresholds into the CGroup constructor, so that self.threshold is present even if CGroup.set_limits() is never called for a particular instance. That will make the original code up in CGroupsTelemetry work under all circumstance. Much smaller change, no duplication of code.
vrdmr
force-pushed
the
vameru-fix-telemetry-bug
branch
2 times, most recently
from
ac3803a
to
91a3371
Compare
jasonzio
requested changes
Nov 14, 2018
vrdmr
force-pushed
the
vameru-fix-telemetry-bug
branch
from
91a3371
to
764f578
Compare
narrieta
approved these changes
Nov 14, 2018
jasonzio
reviewed
Nov 15, 2018
vrdmr
force-pushed
the
vameru-fix-telemetry-bug
branch
from
764f578
to
4843d49
Compare
vrdmr
commented
Nov 15, 2018
jasonzio
reviewed
Nov 15, 2018
vrdmr
force-pushed
the
vameru-fix-telemetry-bug
branch
2 times, most recently
from
6875558
to
133f706
Compare
jasonzio
reviewed
Nov 15, 2018
jasonzio
reviewed
Nov 15, 2018
vrdmr
force-pushed
the
vameru-fix-telemetry-bug
branch
from
133f706
to
052c34c
Compare
jasonzio
approved these changes
Nov 16, 2018
vrdmr
added a commit
that referenced
this pull request
Nov 19, 2018
* Changed local variable name and added traceback for exthandler failures (#1392) * Changed local variable name and added traceback * Changing the traceback location * Fix the threshold telemetry issue (#1394) * Adding the get_limits call within the collect_all_tracked call * Added tests for threshold * Send events when extensions fail to complete operation (#1397) * Bumping up the version to 2.2.34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier the thresholds were being assigned during the set_cgroups_limits (and being maintained in the Cgroup class, and member of _tracked in CGroupTelemetry). The monitor thread wasn't picking up the data and we were seeing
2018/11/07 21:18:42.654547 WARNING ExtHandler Monitor: failed to collect Cgroups performance metrics: 'NoneType' object has no attribute '__getitem__'.This change now explicitly updates the
limits[cgroup_name]dictionary, which is returned by thecollect_all_tracked().Issue #1395, also does half work for #1363
PR information
Quality of Code and Contribution Guidelines