-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vwanConnectivity] Refactor to support multi-region hubs #805
Merged
oZakari
merged 6 commits into
Azure:main
from
sebassem:vwanconnectivity-azfw-policy-per-region
Jul 15, 2024
Merged
[vwanConnectivity] Refactor to support multi-region hubs #805
oZakari
merged 6 commits into
Azure:main
from
sebassem:vwanconnectivity-azfw-policy-per-region
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
2 tasks
oZakari
added
Area: Networking 🌐
Issues / PR's related to Networking
Type: Bug 🪲
Something isn't working
labels
Jul 11, 2024
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
9 tasks
oZakari
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR is changing the way Azure Firewall parameters are handled in the module to be per Hub, currently there are common parameters for Azure Firewall that will be applied to every instance in all hubs. Customers may want to customize the policies, dns servers,.tiers,...etc per region per hub.
This PR fixes/adds/changes/removes
Breaking Changes
parAzFirewallDnsServers
parAzFirewallIntelMode
parAzFirewallDnsProxyEnabled
parAzFirewallTier
parAzFirewallAvailabilityZones
Testing Evidence
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch