Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALZ bicep modules multi-region guidance #804

Merged
merged 21 commits into from
Jul 17, 2024

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Jul 3, 2024

Overview/Summary

This PR is adding examples and guidance on how to deploy ALZ platform resources into multiple regions. It covers hub and spoke and vwan modules

This PR fixes/adds/changes/removes

Closes #375

Breaking Changes

None

Testing Evidence

This PR only has readme changes

As part of this Pull Request I have

@sebassem
Copy link
Contributor Author

sebassem commented Jul 3, 2024

@oZakari @jtracey93 This is a still a WIP but wanted to share an early draft of the hubNetworking multi-region guidance. Please let me know if you have comments/feedback so I can start on the vWan module next.

@sebassem sebassem requested a review from oZakari July 4, 2024 09:55
@sebassem sebassem self-assigned this Jul 7, 2024
@sebassem
Copy link
Contributor Author

This PR is dependent on #805

@sebassem sebassem marked this pull request as ready for review July 14, 2024 05:53
@sebassem sebassem changed the title ALZ bicep modules multi-region support ALZ bicep modules multi-region guidance Jul 14, 2024
@sebassem sebassem requested a review from jtracey93 July 14, 2024 06:05
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sebassem, I think the docs are concise and clear. I have made some updates to the hub networking module readme, particularly with switching to East US and West US since they are paired regions. Also, demonstrates that they will need to look out for the regions that do/dont support availability zones to determine which parameter file to use.

I also removed the example parameter files to avoid bloat as I think it should be pretty easy to follow that they just need to change the regions. Let me know if you object though and we can discuss.

Could you please update the East US 2 example output to West US? After that I think it is good to merge as long as good on your end.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Needs the author to provide feedback label Jul 17, 2024
@oZakari oZakari added Area: Networking 🌐 Issues / PR's related to Networking Type: Documentation 📄 Improvements or additions to documentation labels Jul 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Needs the author to provide feedback label Jul 17, 2024
@sebassem
Copy link
Contributor Author

Hey @sebassem, I think the docs are concise and clear. I have made some updates to the hub networking module readme, particularly with switching to East US and West US since they are paired regions. Also, demonstrates that they will need to look out for the regions that do/dont support availability zones to determine which parameter file to use.

I also removed the example parameter files to avoid bloat as I think it should be pretty easy to follow that they just need to change the regions. Let me know if you object though and we can discuss.

Could you please update the East US 2 example output to West US? After that I think it is good to merge as long as good on your end.

Thanks Zach, screenshot has been updated

@oZakari
Copy link
Contributor

oZakari commented Jul 17, 2024

/azp run validateazcloud

@Azure Azure deleted a comment from azure-pipelines bot Jul 17, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari merged commit b700ac4 into Azure:main Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Feature Request - Multi-Region ALZs
2 participants