-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting minimal network deployment, and fix about modified Modules #711
Conversation
Feature: Added new deployment toggles to hub-spoke (Azure#699)
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcosgm, looks good from a content perspective! There are just a few lint errors and then we should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown updated to pass linter rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @marcosgm!
Overview/Summary
Added an example of parametrization to reduce the infra costs by disabling network security elements
It also fixes the example of customizing logging.bicep but refers to the wrong PS1 file
This PR fixes/adds/changes/removes
Minimalistic network deployment that reduces the cost to almost zero, referred in the sectiosn where we review the parameter files within config/custom-parameters
Proper reference to pipeline-scripts\Deploy-ALZLoggingAndSentinel.ps1
Breaking Changes
No code changes
Testing Evidence
No code changes
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch