Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting minimal network deployment, and fix about modified Modules #711

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

marcosgm
Copy link
Contributor

@marcosgm marcosgm commented Jan 11, 2024

Overview/Summary

Added an example of parametrization to reduce the infra costs by disabling network security elements
It also fixes the example of customizing logging.bicep but refers to the wrong PS1 file

This PR fixes/adds/changes/removes

Minimalistic network deployment that reduces the cost to almost zero, referred in the sectiosn where we review the parameter files within config/custom-parameters
Proper reference to pipeline-scripts\Deploy-ALZLoggingAndSentinel.ps1

Breaking Changes

No code changes

Testing Evidence

No code changes

As part of this Pull Request I have

@marcosgm
Copy link
Contributor Author

marcosgm commented Jan 11, 2024

@microsoft-github-policy-service agree company="Microsoft"

@marcosgm marcosgm changed the title Tiny Doc fix about modified Modules Documenting minimal network deployment, and fix about modified Modules Jan 11, 2024
oZakari

This comment was marked as outdated.

@oZakari oZakari self-requested a review January 12, 2024 04:19
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcosgm, looks good from a content perspective! There are just a few lint errors and then we should be good to go.

Copy link
Contributor Author

@marcosgm marcosgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown updated to pass linter rules

@marcosgm marcosgm requested a review from oZakari January 22, 2024 17:28
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marcosgm!

@oZakari oZakari merged commit 5e40e5a into Azure:main Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants