Feature: Added new deployment toggles to hub-spoke (#699) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added deployment toggle for feature parity with vwan * Fix and simplify conditions for deployment * Add missing paranthesis * Update condition logic and params * Generate Parameter Markdowns [oZakari/dad46f42] * Removed extra paranthesis * Fixed express route gateway param descriptions * Generate Parameter Markdowns [oZakari/17edce48] * Remove check to see if config params are empty * Update infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com> * Update infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
marcosgm
pushed a commit
that referenced
this pull request
Apr 15, 2024
* Fix version references for known issue #1 * Update to match modules for known issue 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added deployment toggle for feature parity with vwan
Fix and simplify conditions for deployment
Add missing paranthesis
Update condition logic and params
Generate Parameter Markdowns [oZakari/dad46f42]
Removed extra paranthesis
Fixed express route gateway param descriptions
Generate Parameter Markdowns [oZakari/17edce48]
Remove check to see if config params are empty
Update infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep
Update infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch