Add if (parAzBastionEnabled) to nsg create bastion

[woutermation]

Fixes #573

Overview/Summary

When setting Bastion to disabled the NSG is still deployed, expect that the NSG is not deployed

By adding if (parAzBastionEnabled) to the NSG creation this is fixed

This PR fixes/adds/changes/removes

Change hubNetworking.bicep line 368 with

resource resBastionNsg 'Microsoft.Network/networkSecurityGroups@2021-08-01' = if (parAzBastionEnabled) {
}

Breaking Changes

None

Testing Evidence

NSG is not created ;-)

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

[jtracey93]

Hey @woutermation,

Thanks for the PR, much appreciated.

I think one more thing needs changing on line 287 to ensure that if Bastion isn't enabled the NSG isn't tried to be referenced:

https://github.com/woutermation/ALZ-Bicep/blob/woutermation/issue573/infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep#L287-L291

Can you add to the condition that already exists to also check for parAzBastionEnabled being true?

Thanks

[woutermation]

Good catch, I removed de AzureBastionSubnet from my parameter file that's why it didn't show up during testing (my bad ;-)) and note to self to always test with the default param file.

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).