Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bastion NSG deployed when parAzBastionEnabled -eq $false #573

Closed
woutermation opened this issue Jul 12, 2023 · 1 comment · Fixed by #575 or #604
Closed

Bastion NSG deployed when parAzBastionEnabled -eq $false #573

woutermation opened this issue Jul 12, 2023 · 1 comment · Fixed by #575 or #604

Comments

@woutermation
Copy link
Contributor

Describe the bug

When setting Bastion to disabled the NSG is still deployed

To Reproduce

parAzastionEnabled set to false

  1. Deploy
  2. Check NSG

Expected behaviour

Expect that the NSG is not deployed; and can be fixed in hubNetworking.bicep line 368

resource resBastionNsg 'Microsoft.Network/networkSecurityGroups@2021-08-01' = if (parAzBastionEnabled) {
}
@jtracey93
Copy link
Collaborator

Thanks @woutermation for the issue

Would you like to submit a PR to fix this that we can merge in?

Let me know

Thanks

Jack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants