Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced DDoS Standard with DDoS Network Protection #396

Merged
merged 4 commits into from
Nov 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra-as-code/bicep/modules/hubNetworking/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Module deploys the following resources:
- Azure Firewall
- Azure Firewall Policies
- Private DNS Zones
- DDos Standard Plan
- DDoS Network Protection Plan
- Bastion
- Route Table

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ param parAzBastionSku string = 'Standard'
@description('NSG Name for Azure Bastion Subnet NSG. Default: nsg-AzureBastionSubnet')
param parAzBastionNsgName string = 'nsg-AzureBastionSubnet'

@description('Switch to enable/disable DDoS Standard deployment. Default: true')
@description('Switch to enable/disable DDoS Network Protection deployment. Default: true')
param parDdosEnabled bool = true

@description('DDoS Plan Name. Default: {parCompanyPrefix}-ddos-plan')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ The module does not generate any outputs.

> For the examples below we assume you have downloaded or cloned the Git repo as-is and are in the root of the repository as your selected directory in your terminal of choice.
<!-- markdownlint-disable -->
> **Important:** If you decide to not use a DDoS Standard plan in your environment and therefore leave the parameter `parDdosProtectionPlanId` as an empty string (`''`) then the policy Enable-DDoS-VNET will not be assigned at connectivity or landing zone Management Groups to avoid VNET deployment issues. For deployment in Azure China, leave the parameter `parDdosProtectionPlanId` as an empty string (`''`) because the DDoS Protection feature is not available in Azure China.
> **Important:** If you decide to not use a DDoS Network Protection plan in your environment and therefore leave the parameter `parDdosProtectionPlanId` as an empty string (`''`) then the policy Enable-DDoS-VNET will not be assigned at connectivity or landing zone Management Groups to avoid VNET deployment issues. For deployment in Azure China, leave the parameter `parDdosProtectionPlanId` as an empty string (`''`) because the DDoS Protection feature is not available in Azure China.
>
> However, if you later do decide to deploy an DDoS Standard Plan, you will need to remember to come back and update the parameter `parDdosProtectionPlanId` with the resource ID of the DDoS Standard Plan to ensure the policy is applied to the relevant Management Groups. You can then use a policy [remediation task](https://docs.microsoft.com/azure/governance/policy/how-to/remediate-resources) to bring all non-compliant VNETs back into compliance, once a [compliance scan](https://docs.microsoft.com/azure/governance/policy/how-to/get-compliance-data#evaluation-triggers) has taken place.
> However, if you later do decide to deploy an DDoS Network Protection Plan, you will need to remember to come back and update the parameter `parDdosProtectionPlanId` with the resource ID of the DDoS Network Protection Plan to ensure the policy is applied to the relevant Management Groups. You can then use a policy [remediation task](https://docs.microsoft.com/azure/governance/policy/how-to/remediate-resources) to bring all non-compliant VNETs back into compliance, once a [compliance scan](https://docs.microsoft.com/azure/governance/policy/how-to/get-compliance-data#evaluation-triggers) has taken place.
<!-- markdownlint-restore -->

### Azure CLI
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
"identity": {
"type": "SystemAssigned"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
"identity": {
"type": "SystemAssigned"
}
}
}
2 changes: 1 addition & 1 deletion infra-as-code/bicep/modules/vwanConnectivity/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Module deploys the following resources which can be configured by parameters:
- ExpressRoute Gateway
- Azure Firewall
- Azure Firewall policy
- DDoS Standard Plan
- DDoS Network Protection Plan
- Private DNS Zones - Details of all the Azure Private DNS zones can be found here --> [https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-dns#azure-services-dns-zone-configuration](https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-dns#azure-services-dns-zone-configuration)

## Parameters
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ param parVpnGatewayScaleUnit int = 1
@description('The scale unit for this ExpressRoute Gateway: Default: 1')
param parExpressRouteGatewayScaleUnit int = 1

@description('Switch to enable/disable DDoS Standard deployment. Default: true')
@description('Switch to enable/disable DDoS Network Protection deployment. Default: true')
param parDdosEnabled bool = true

@description('DDoS Plan Name. Default: {parCompanyPrefix}-ddos-plan')
Expand Down