Replaced DDoS Standard with DDoS Network Protection

[lachaves]

Overview/Summary

As per ADO User Story 24459, performing a replacement of "DDoS Standard" with "DDoS Network Protection" in all the ALZ-Bicep repo.

This PR fixes/adds/changes/removes

1. Closes Issue Replace DDoS Standard with DDoS Network Protection #395

Breaking Changes

NA

Testing Evidence

NA

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• [ X] Checked for duplicate Pull Requests
• [ X] Associated it with relevant GitHub Issues
• [X ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• [X ] Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• [X ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

[ghost]

Hey lachaves, thanks for creating this PR.

We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍

Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.

So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.

However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.

Thanks from your friendly msft-bot.

[jtracey93]

Thanks @lachaves. Can you rollback/not make changes to these files please as we will pull these in from upstream ESLZ repo:

1. infra-as-code/bicep/modules/policy/assignments/lib/china/policy_assignments/policy_assignment_es_enable_ddos_vnet.tmpl.json
2. infra-as-code/bicep/modules/policy/assignments/lib/policy_assignments/policy_assignment_es_enable_ddos_vnet.tmpl.json

[lachaves]

@jtracey93 I believe it should now be ready for merging as I rolled back the changes in both files. Please check and let me know if still missing something.

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

LGTM