Response to FRs - Issues #267 and #290 - POC in RG Name and Deployment Snippets

[4pplied]

Overview/Summary

Change in the READMEs of each of the modules which has a deployment snippet and also amendment of Resource Group Names to conform to CAF Standardisation. A PR to work on Issue #267 and #290

This PR fixes/adds/changes/removes

1. Adds CAF Standardisation to Resource Group Names
2. Adds deployment names into snippets
3. Conforms deployment methods including names to CARML standards

Breaking Changes

1. N/A - documentation

Testing Evidence

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

[jtracey93]

@JamJarchitect Can we do this for all Bicep docs (like orchestration and CRML etc.)

Cheers

[4pplied]

@JamJarchitect Can we do this for all Bicep docs (like orchestration and CRML etc.)

Cheers

This should now be done @jtracey93

[jtracey93]

@JamJarchitect sorry buddy.

Can we add and alz prefix to the deployment names just so they are easy to find/remember for users?

Also do we need to add a note for all bash usage that pwsh needs to be installed for the inputObject to work?

[4pplied]

@JamJarchitect sorry buddy.

Can we add and alz prefix to the deployment names just so they are easy to find/remember for users?

Also do we need to add a note for all bash usage that pwsh needs to be installed for the inputObject to work?

@jtracey93 prefix added, naming conventions done, NOTE added on bash on Private DNS zone as well. Any reviewer(s) are welcome!

[jtracey93]

This looks good to me.

@rjygraham would you mind casting a 2nd set of eyes over this.

@msftbot do not merge until @jtracey93 & @rjygraham have approved

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

@msftbot do not merge until @jtracey93 Jack Tracey FTE & @rjygraham Ryan Graham FTE have approved

[4pplied]

/azp run validateazcloud

[azure-pipelines]

Commenter does not have sufficient privileges for PR 312 in repo Azure/ALZ-Bicep

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

@rjygraham are you good to give this a review now @JamJarchitect has converted the bash to native cli?

[jtracey93]

sorry to chase @rjygraham have you had a chance to review this one, or do we need to reassign?

[oZakari]

@jtracey93 This looks good to me.

[jtracey93]

@JamJarchitect can we resolve the merge conflicts here and then we can look to merge 👍

[jtracey93]

Hey @JamJarchitect,

Finally found time to review, but apologies for the amount of comments

[jtracey93]

Thanks @JamJarchitect 2 things to fix and think we are good

[4pplied]

@jtracey93 those last two amendments were done. should all be good now!

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).