Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Feature Request - Update Resource Group Names From POC #290

Closed
jtracey93 opened this issue Jul 19, 2022 · 2 comments
Closed

💡 Feature Request - Update Resource Group Names From POC #290

jtracey93 opened this issue Jul 19, 2022 · 2 comments
Assignees

Comments

@jtracey93
Copy link
Collaborator

jtracey93 commented Jul 19, 2022

Describe the solution you'd like

In some of our module docs we need to create Resource Groups to deploy resources into. Today some of the Resource Group Names have references to POC etc. in them which we should change to something that aligns more to what we'd normally expect to see in a normal "production" deployment.

Some examples of POC nomenclature and differences in modules:

  • https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/spokeNetworking#deployment
  • https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/hubNetworking#deployment
  • https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/logging#deployment

As you can see in the community create hubPeeredSpoke module there is a good example of the resource group name being changed from POC: https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/orchestration/hubPeeredSpoke/hubPeeredSpoke.bicep#L28

Describe alternatives you've considered

N/A

Additional context

  • Try to follow CAF naming recommendations and standards: https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations
  • Update pipelines and other places old Resource Group Names are used as well as modules and their docs
  • Review limits on Resource Group naming here: https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftresources

Naming Pattern Suggestion

rg-${parTopLevelManagementGroupPrefix}-hub-networking-prod-001 - Hub Networking Resource Group rg-${parTopLevelManagementGroupPrefix}-logging-auto-prod-001 - Logging Resource Group

@jtracey93
Copy link
Collaborator Author

This is linked to PR #312

@jtracey93 jtracey93 assigned 4pplied and unassigned 4pplied Sep 7, 2022
jtracey93 pushed a commit that referenced this issue Nov 3, 2022
@jtracey93
Copy link
Collaborator Author

#312 closes this

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants