Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Resource Group output #200

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

johnlokerse
Copy link
Contributor

@johnlokerse johnlokerse commented Apr 6, 2022

Overview/Summary

I added outputs for resource groups, so these values can be used when resource groups are created.

This PR fixes/adds/changes/removes

  1. Adds resource group outputs

Breaking Changes

None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 6, 2022
@jtracey93
Copy link
Collaborator

Hey @johnlokerse,

We recently had this as a PR from @KiZach here: #194

Can I ask why we need this? Interested to understand before we merge 👍

Thanks

Jack

@johnlokerse
Copy link
Contributor Author

Hey @jtracey93 - I can see some use cases regarding these outputs:

  • I have seen scenario's where this is used for informational/debugging purposes
  • Output needed for other scripts (most of the time I use a mix of Bicep and other tech such as Azure CLI)
  • Output from module to resource

@jtracey93
Copy link
Collaborator

/azp run e2e

@jtracey93 jtracey93 self-requested a review April 6, 2022 15:46
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jtracey93 jtracey93 merged commit ff088e3 into Azure:main Apr 6, 2022
@johnlokerse johnlokerse deleted the add-rg-output branch May 5, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants