Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output added to resourceGroup module. #194

Closed
wants to merge 1 commit into from

Conversation

KiZach
Copy link
Contributor

@KiZach KiZach commented Mar 23, 2022

Overview/Summary

Added outputs to make depends-on support better for sub modules deploying into the created resource group.

This PR fixes/adds/changes/removes

Support for using an output to make dependencies in bicep file.

Breaking Changes

None

Testing Evidence

Only adds output to module, so tested it with a simple main bicep file.

Inputs:
image

Outputs:
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jtracey93 jtracey93 self-requested a review March 23, 2022 15:43
@jtracey93 jtracey93 self-assigned this Mar 23, 2022
@jtracey93
Copy link
Collaborator

Thanks @KiZach,

Out of interest how does this help as you cannot use the name or ID from an output of one module to pass into another module today as it creates a circular dependency as per:

image

Just want to understand before we look to merge this PR

Thanks

Jack

@KiZach
Copy link
Contributor Author

KiZach commented Mar 24, 2022

Hi @jtracey93

You are right, did some more tests and found why it was working on another Bicep project.

I used the CARML module https://github.com/Azure/ResourceModules/tree/main/arm/Microsoft.Resources/resourceGroups in another project, this has the outputs. And on this project the RG name was used as a param not scope to 'sub' modules for extracting the 'applicationname' that was part of the resource group name.

So I think this PR can be closed.

@KiZach KiZach closed this Mar 24, 2022
@KiZach KiZach deleted the resourcegroup-outputs branch March 24, 2022 06:23
@jtracey93 jtracey93 mentioned this pull request Apr 6, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants