Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upped aliases API version to non-preview #198

Merged
merged 13 commits into from
Apr 2, 2022
Merged

Upped aliases API version to non-preview #198

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
51e16b2
Upped aliases API version to non-preview
johnlokerse Mar 30, 2022
36d2494
Added parTags, parManagementGroupId, parSubscriptionOwnerId
johnlokerse Mar 30, 2022
cc3c381
Updated readme, updated example params
johnlokerse Mar 30, 2022
f43008e
Implemented review feedback
johnlokerse Mar 30, 2022
0851411
Added managementGroup reference
Mar 31, 2022
478a4a3
Made parManagementGroupId, parSubscriptionOwnerId optional
Mar 31, 2022
8f66921
Turned the ternary check around
Mar 31, 2022
0df3af0
Typo fixes
Mar 31, 2022
46a1ff0
Removed (optional) in README
Mar 31, 2022
9829c37
updates to params min and location for upcomming change and update tests
jtracey93 Apr 1, 2022
e4fc83f
Merge pull request #1 from jtracey93/pr/johnlokerse/198
johnlokerse Apr 1, 2022
8722630
Removed block quote because of markdownlinter error
johnlokerse Apr 1, 2022
d0b18a8
changes for module docs consistency
jtracey93 Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion infra-as-code/bicep/CRML/subscriptionAlias/subscriptionAlias.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
SUMMARY: The Subscription Alias module deploys an EA, MCA or MPA Subscription into the tenants default Management Group
DESCRIPTION: The Subscription Alias module deploys an EA, MCA or MPA Subscription into the tenants default Management Group as per the docs here: https://docs.microsoft.com/azure/cost-management-billing/manage/programmatically-create-subscription
AUTHOR/S: jtracey93
johnlokerse marked this conversation as resolved.
Show resolved Hide resolved
VERSION: 1.0.0
VERSION: 1.1.0
- Updated version of the API
- Added additional properties: parTags, parManagementGroupId, parSubscriptionOwnerId and subscriptionTenantId
*/

targetScope = 'tenant'
Expand All @@ -13,6 +15,15 @@ param parSubscriptionName string
@description('The full resource ID of billing scope associated to the EA, MCA or MPA account you wish to create the subscription in.')
param parSubscriptionBillingScope string

@description('Tags you would like to be applied')
param parTags object = {}

@description('The ID of the management group where the subscription will be placed. Also known as the parent management group.')
param parManagementGroupId string
johnlokerse marked this conversation as resolved.
Show resolved Hide resolved

@description('The ID of the responsible user for the subscription.')
johnlokerse marked this conversation as resolved.
Show resolved Hide resolved
param parSubscriptionOwnerId string
johnlokerse marked this conversation as resolved.
Show resolved Hide resolved

@allowed([
'DevTest'
'Production'
Expand All @@ -23,6 +34,12 @@ param parSubscriptionOfferType string = 'Production'
resource resSubscription 'Microsoft.Subscription/aliases@2021-10-01' = {
name: parSubscriptionName
properties: {
additionalProperties: {
tags: parTags
managementGroupId: parManagementGroupId
subscriptionOwnerId: parSubscriptionOwnerId
subscriptionTenantId: tenant().tenantId
johnlokerse marked this conversation as resolved.
Show resolved Hide resolved
}
displayName: parSubscriptionName
billingScope: parSubscriptionBillingScope
workload: parSubscriptionOfferType
Expand Down