Upped aliases API version to non-preview

[johnlokerse]

Checked if the current properties are still valid. With the newer version Microsoft.Subscription/aliases there are more properties present, tags for example.
Link to msdocs: https://docs.microsoft.com/en-us/azure/templates/microsoft.subscription/2021-10-01/aliases?tabs=bicep

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant ADO items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation.

[jtracey93]

Hey @johnlokerse,

Thanks for this, do you also want to add the additional properties as input parameters for this? I think they would be useful and has been on my mind to do 👍

Let me know

Thanks

Jack

[johnlokerse]

Sure I will try to update it tonight 👍

[johnlokerse]

@jtracey93 I added the properties tags, managementGroupId, subscriptionTenantId and subscriptionOwnerId. The latter is unclear to me. I couldn't find it in the Azure Portal either. Is it the account admin under Subscription > Properties?

[jtracey93]

Thanks for your work here @johnlokerse a few changes please 👍

[johnlokerse]

@jtracey93 Implemented your feedback! :-)

[jtracey93]

Hey @johnlokerse,

Thanks for making those changes. A few more from this pass/review.

Could you also provide some testing evidence/screenshots? (if not possible let me know and we can do some testing for you)

Thanks

Jack 👍

[johnlokerse]

I can provide a screenshot that shows the created subscription with the default tagging. So the changes work! The subscriptionOwner is set as myself, so that answers my question about what "subscriptionOwner" means. It's just a RBAC permission.

[johnlokerse]

@jtracey93 If I can find time I will take a look at the proposed changes later. 😃

[johnlokerse]

Something like this @jtracey93? Made parManagementGroupId and parSubscriptionOwnerId optional using an empty string + empty() check. Tested while creating a new subscription. It works.

[jtracey93]

Something like this @jtracey93 Jack Tracey FTE? Made parManagementGroupId and parSubscriptionOwnerId optional using an empty string + empty() check. Tested while creating a new subscription. It works.

looking good. have you tested with them not empty also?

[johnlokerse]

Something like this @jtracey93 Jack Tracey FTE? Made parManagementGroupId and parSubscriptionOwnerId optional using an empty string + empty() check. Tested while creating a new subscription. It works.

looking good. have you tested with them not empty also?

Yes. Tested with:

• Empty (both)
• Empty (one empty, one defined)
• Both defined

[jtracey93]

Last 2 pieces and we are there 👍👍👍

[johnlokerse]

Implemented feedback

Edit: @jtracey93 I see a requested change, but I cannot find it...

[jtracey93]

Implemented feedback

Edit: @jtracey93 Jack Tracey FTE I see a requested change, but I cannot find it...

No worries i will review today

[jtracey93]

@johnlokerse can you merge this PR to your forks branch johnlokerse#1

[johnlokerse]

@jtracey93 There was an error regarding the markdownlinter. Fixed it and the actions are now good.