Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ViewLocator from MVVM and Xplat templates #187

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Takoooooo
Copy link
Contributor

I guess later we will need to make some solution for navigation that will be compatible with AOT
fixes #177

@Takoooooo Takoooooo requested a review from maxkatz6 April 17, 2023 13:46
@Mrxx99
Copy link
Contributor

Mrxx99 commented Apr 17, 2023

I really liked the simple ViewLocator...
If someone wants to use NativeAOT he has to educate himself about no reflection usage anyway, so I would not see that as a concern

@wieslawsoltes
Copy link

I really liked the simple ViewLocator... If someone wants to use NativeAOT he has to educate himself about no reflection usage anyway, so I would not see that as a concern

You can have source generator based view locator without reflection.

@wieslawsoltes
Copy link

I really liked the simple ViewLocator... If someone wants to use NativeAOT he has to educate himself about no reflection usage anyway, so I would not see that as a concern

You can have source generator based view locator without reflection.

If anyone needs it https://github.com/zkSNACKs/WalletWasabi/blob/a595040f630e87fbe00d63505a8010f2133a9c53/WalletWasabi.Fluent.Generators/StaticViewLocatorGenerator.cs#L12

@maxkatz6 maxkatz6 merged commit ee2fc70 into master Apr 19, 2023
@maxkatz6 maxkatz6 deleted the remove-viewLocator branch March 8, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ViewLocator or hide behind a parameter
4 participants