Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ViewLocator or hide behind a parameter #177

Closed
maxkatz6 opened this issue Mar 4, 2023 · 1 comment · Fixed by #187
Closed

Remove ViewLocator or hide behind a parameter #177

maxkatz6 opened this issue Mar 4, 2023 · 1 comment · Fixed by #187

Comments

@maxkatz6
Copy link
Member

maxkatz6 commented Mar 4, 2023

Currently ViewLocator in the templates is an easy way to make configure multiple view + view models soltuion. But even then for proper navigation it would require a bit more research and understanding, than simple view locator can give.

On the other side, current view locator is not trimming nor AOT friendly. Making it so would make default template way too complex.

Proposal: in the default templates we should remove view locator. Main view model is already set implicitly on the main window/view by the App.xaml.cs.

@giopalma
Copy link

Documentation is not updated.
For example https://docs.avaloniaui.net/tutorials/todo-list-app uses old template with ViewLocator and the tutorial can't be reproduced step-by-step with the new template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants