Update toolkit plugin to v2.7

[noahtallen]

Changes proposed in this Pull Request

Update toolkit plugin to v2.7.

Includes these changes (see https://github.com/Automattic/wp-calypso/commits/master/apps/editing-toolkit)

• Begin loading patterns from an API. (Editing Toolkit: Load patterns from the rest API endpoint #45926) (reverted)
• New checkout style. (Composite-checkout: Remove "...UI" pattern for styled components #46169)
• Improve styles of premium content login button. (Add fill and outline style to premium content login button #46227)
• Add new coming soon page pattern. (Add/coming soon editable page to all sites #46179)
• Improve styles of recurring payments block. (Premium Content: Fix logged-out view button alignment  #46125)
• Add extra space to the first block when the page title is hidden. (Add vertical space above the first content block when the page title is hidden #46003)
• Update the category of the premium content block. (Change Premium Content Block Category #45978)

cc @roo2 @arcangelini @krymson24

Testing instructions

• Ensure the above PRs work on both simple and atomic sites.

[matticbot]

Test live: https://calypso.live/?branch=update/toolkit-plugin-2.7

[matticbot]

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D50376-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

This diff should not be used any longer. see the diff at the end of the page instead.

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[glendaviesnz]

@noahtallen what is the normal process if we get another change backed up behind an editing toolkit update? eg. we have another Newspack block update to bring in - is it easier to just merge this first and then create another PR to bring that in? PR for this version update at #46023

[noahtallen]

Nope, I think we can go ahead and bring that update into this PR, given it's mainly about updating newspack anyways! I haven't had time to test this yet, so anyone can feel free to incorporate, test and ship this along with that update :)

[arcangelini]

Tested, looks good to me. Thanks @noahtallen

[noahtallen]

The teamcity unit tests in D50376-code are consistently indicating an issue in the wpcom blog posts rest API controller, so we cannot move forward with this until that's fixed.

[glendaviesnz]

@arcangelini looks like the broken tests may be related to Automattic/newspack-blocks@dd69bc2, commenting out some of this got rid of at least 3 of the failing tests

[arcangelini]

Oof, ok I am pinging @laurelfulford because it looks like she worked on that PR. Hopefully this isn't caused by the one line of code I added min-width: 0; hahaha.

[laurelfulford]

Thanks for the ping on this! I'm far from an expert on Teamcity tests, but I did some digging:

Two of the errors look like they have to do with the rest fields that have been added since the last update to the Newspack Blocks -- the tests don't expect them to be there.test_get_item_schema() needs to be updated to account for 2 more fields, and test_get_post_edit_context_properties() needs to be updated to include the names of the fields, newspack_blocks_post_format, and newspack_post_sponsors. Here's an example from a past update: 208502-wpcom.

The date errors I'm less sure about -- did they stop happening when the Newspack Blocks update was removed, too?

[noahtallen]

For the time being, I will have to revert the newspack update. We need to create a new PR which updates newspack, and make sure that we merge updates to the WordPress.com unit tests at the same time as we deploy the WordPress.com code which includes the newspack update.

I'm reverting because I'm unsure how long it will take to sort out the tests, and there a lot of unreleased fixes to the editing toolkit plugin.

[jeffersonrabb]

For the time being, I will have to revert the newspack update. We need to create a new PR which updates newspack, and make sure that we merge updates to the WordPress.com unit tests at the same time as we deploy the WordPress.com code which includes the newspack update.

Hi @noahtallen I'm looking into updating those tests but it will be a little while, so reverting is a good strategy for now.

the code is out of date, and we are no longer including newspack changes

[noahtallen]

Everything is testing well for me on both simple and atomic sites, so I think this is ready to go 👍

[noahtallen]

NOTE: avoid deploying again until performance issues are addressed.

out of date

[matticbot]

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D50900-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

[noahtallen]

superseded by #46444