Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Premium Content Block Category #45978

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

krymson24
Copy link
Contributor

@krymson24 krymson24 commented Sep 29, 2020

Changes proposed in this Pull Request

  • Currently, the Premium Content block does not show up in the "Earn" category whenever you search for "Earn" or "Premium Content" in the block search. However, it shows up in the "New" category.
  • This PR removes the Premium Content block from the "New" category, and adds it to the "Earn" category.

Testing instructions

  • Go to https://wordpress.com/block-editor and select a site
  • Click on the "+" button at the top left corner of the block editor to search for available Blocks you can use
  • Type in "Earn" or "Premium Content". You should see the Premium Content block under the "Earn" category

GIFs

2020-09-28 19 41 43

Fixes 232-gh-dotcom-manage

…ks showcase and switch category from design to earn
@krymson24 krymson24 added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Earn labels Sep 29, 2020
@krymson24 krymson24 requested a review from a team September 29, 2020 00:27
@krymson24 krymson24 self-assigned this Sep 29, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D50318-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Non-blocking: I wonder if we should also move the Premium Content buttons and Premium Content login button blocks to the Earn category.

@krymson24
Copy link
Contributor Author

@mmtr I was curious about that too -- since it seemed like the original category for Premium Content was "Design". @davemart-in what do you think? If you look at my GIF, what @mmtr is referring to is in the "Design" category. Should we move those too? I'll merge this in first, and then if you think that's necessitate changes, I can create another ticket and PR for those.

@krymson24 krymson24 merged commit fa9f663 into master Sep 29, 2020
@krymson24 krymson24 deleted the fix/premium-content-block-category branch September 29, 2020 21:28
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Earn [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants