Framework: Add the commit sha1 information in the environment badge (on hover) #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
force-pushed
the
add/badge-commit-id
branch
3 times, most recently
from
7988ddc to
50503ab
Compare
Tug
added
[Status] Needs Review
|
Works well 👍 |
…h name in the environment badge
Tug
force-pushed
the
add/badge-commit-id
branch
from
50503ab to
17c575e
Compare
Tug
added a commit
that referenced
this pull request
Jan 8, 2016
Framework: Add the commit sha1 information in the environment badge (on hover)
Tug
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few thing from #1531 :
getCurrentBranchName()now returns aStringinstead of aBufferAnd adds a new information: the last commit id (or sha1 checksum) available when hovering the branch name in the environment badge
Context
This is useful for a multi branch version of the application (See: https://github.com/Automattic/calypso-live-branches). This way we can ensure the server has updated our changes.