Framework: Display the name of the current branch with the environment badge #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t badge The idea is that it is useful to be remembered of the current branch when you are testing. Branch name is not displayed when: - Git is not available - The project is not a git repository - The current branch is master Also, this is going to be really useful for a multiple version application of calypso.
Tug
added
Accessibility
lancewillett
added
the
[Status] Needs Review
Tug
added
Framework
and removed
Accessibility
|
cc @lancewillett, @mtias |
|
Quick notes from testing the branch in Firefox, local install of latest master: I switched to this branch, but the badge didn't update. :(
|
|
OK — after a new
|
Tug
force-pushed
the
add/dev-show-branch-name
branch
from
9006204 to
55f5a20
Compare
|
Let's wait for #1322 to be merged and review this change again! |
|
@Tug this seems like a nice improvement. I don't think we need to wait on the design update to get it in, though :) |
|
Ok :) let's merge it then? |
|
🚢 |
|
👍 |
mtias
removed
the
[Status] Needs Review
Tug
added a commit
that referenced
this pull request
Dec 15, 2015
Framework: Display the name of the current branch with the environment badge
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that it is useful to be remembered of the current branch when you are testing.
This is what it looks like:
Branch name is not displayed when:
Also, this is going to be really useful for a multiple versions application of calypso.