Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: update Node to version 8 LTS (carbon) #19317

Merged
merged 10 commits into from
Nov 14, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
save-exact = true

package-lock = false
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v6.11.5
v8.9.1
7 changes: 2 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:6.11.5
FROM node:8.9.1
MAINTAINER Automattic

WORKDIR /calypso
Expand All @@ -25,12 +25,9 @@ RUN bash /tmp/env-config.sh
# and should only change as often as the dependencies
# change. This layer should allow for final build times
# to be limited only by the Calypso build speed.
#
# Sometimes "npm install" fails the first time when the
# cache is empty, so we retry once if it failed
COPY ./package.json ./npm-shrinkwrap.json /calypso/
RUN true \
&& npm install --production || npm install --production \
&& npm install --production \
&& rm -rf /root/.npm \
&& true

Expand Down
2 changes: 1 addition & 1 deletion circle.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
machine:
node:
version: 6.11.5
version: 8.9.1
test:
pre:
- ? |
Expand Down
Loading