Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: update Node to version 8 LTS (carbon) #19317

Merged
merged 10 commits into from
Nov 14, 2017
Merged

Build: update Node to version 8 LTS (carbon) #19317

merged 10 commits into from
Nov 14, 2017

Commits on Nov 14, 2017

  1. Update to node 8.9.1

    @sirreal
    sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    edeb0f9 View commit details
    Browse the repository at this point in the history

  2. Remove preshrinkwrap which was causing infinite loop

    @sirreal
    sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    bcc52f9 View commit details
    Browse the repository at this point in the history

  3. Simplified update-deps script for npm@5 

    Don't run "npm install" twice, this was workaround for older npm
peculiarities.

Remove the `--dev` flag from `npm shrinkwrap` as it's now the default.
    @sirreal
    Daniel Rey Lopez authored and sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    b395c08 View commit details
    Browse the repository at this point in the history

  4. Disable package-lock.json generation in config 

    We'll continue to use `npm-shrinkwrap.json` which serves the same
purpose.
    @sirreal
    Daniel Rey Lopez authored and sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    e1db600 View commit details
    Browse the repository at this point in the history

  5. Remove optional dependencies from the shrinkwrap. 

    Optional dependencies will continue to be installed if supported. This
will generate the same shrinkwrap independent of the operating system
where the shrinkwrap is generated.

This was an annoyance where `fsevents` would be added or removed from
the shrinkwrap frequently.
    @sirreal
    Daniel Rey Lopez authored and sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    02837bb View commit details
    Browse the repository at this point in the history

  6. Remove duplicate npm install from Dockerfile

    @sirreal
    sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    0632304 View commit details
    Browse the repository at this point in the history

  7. Revert removal of optional deps from shrinkwrap 

    Change in 01dee67 appears to break
docker builds on osx
    @sirreal
    sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    06e28b5 View commit details
    Browse the repository at this point in the history

  8. Move uglify-js to dependencies 

    It's used by `bin/minify.js`, which is called as part of production
builds after `npm install --production`.

This was breaking local docker builds.
    @sirreal
    sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    02dcba3 View commit details
    Browse the repository at this point in the history

  9. Remove retry description

    @sirreal
    sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    5fb88bd View commit details
    Browse the repository at this point in the history

  10. Regenerate shrinkwrap

    @sirreal
    sirreal committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    95c7126 View commit details
    Browse the repository at this point in the history