Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block-level duotone from skatepark patterns and templates #6884

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Remove block-level duotone from skatepark patterns and templates #6884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skatepark/block-templates/page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<!-- wp:group {"align":"full"} -->
<div class="wp-block-group">
<!-- wp:post-featured-image {"align":"full","style":{"color":{"duotone":["#000","#B9FB9C"]}}} /--></div>
<!-- wp:post-featured-image {"align":"full"} /--></div>
<!-- /wp:group -->

<!-- wp:post-content {"layout":{"inherit":true},"lock":{"move":false,"remove":true}} /-->
Expand Down
2 changes: 1 addition & 1 deletion skatepark/patterns/blog-posts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<!-- /wp:separator --></div>
<!-- /wp:group -->

<!-- wp:post-featured-image {"isLink":true,"style":{"color":{"duotone":["#000","#B9FB9C"]}}} /-->
<!-- wp:post-featured-image {"isLink":true} /-->

<!-- wp:post-title {"isLink":true,"style":{"typography":{"fontSize":"var(--wp--custom--font-sizes--normal)"},"spacing":{"margin":{"bottom":"calc( 0.5 * var(--wp--custom--gap--vertical) )"}}}} /-->

Expand Down
2 changes: 1 addition & 1 deletion skatepark/patterns/columns-in-container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<div style="height:40px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:image {"align":"wide","id":26,"sizeSlug":"large","linkDestination":"none","style":{"color":{"duotone":["#000","#B9FB9C"]}}} -->
<!-- wp:image {"align":"wide","id":26,"sizeSlug":"large","linkDestination":"none"} -->
<figure class="wp-block-image alignwide size-large"><img src="<?php echo get_stylesheet_directory_uri() . '/assets/images/riding-skateboard.jpeg'; ?>" alt="<?php echo esc_html__( 'Close-up of a person riding a skateboard, focusing on their feet and the board. One foot is on the board, while the other foot is up, in motion. A skatepark is blurred in the background.', 'skatepark' ); ?>" class="wp-image-26"/></figure>
<!-- /wp:image -->

Expand Down
2 changes: 1 addition & 1 deletion skatepark/patterns/mixed-media-in-container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<div style="height:40px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:image {"sizeSlug":"large","style":{"color":{"duotone":["#000","#BFF5A5"]}}} -->
<!-- wp:image {"sizeSlug":"large"} -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the theme.json for skatepark and see core/image is using the default duotone filter which is ["#000","#B9FB9C"]. This image uses a slightly different (more muted) green of #BFF5A5. I'm not sure if that was originally intentional or a mistake. I don't think anyone would notice the change, but I wanted to point it out here to make sure.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a precedent for changing from #BFF5A5 to #B9FB9C, and honestly can't imagine someone would visually notice the distinction between the two, so I don't think this should be a blocker.

<figure class="wp-block-image size-large"><img src="<?php echo get_stylesheet_directory_uri() . '/assets/images/skateboard-sideways.jpg'; ?>" alt="<?php echo esc_attr__( 'A skateboard laying on its side on top of concrete.', 'skatepark' ); ?>"/></figure>
<!-- /wp:image -->

Expand Down