-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove block-level duotone from skatepark patterns and templates #6884
Conversation
@@ -27,7 +27,7 @@ | |||
<div style="height:40px" aria-hidden="true" class="wp-block-spacer"></div> | |||
<!-- /wp:spacer --> | |||
|
|||
<!-- wp:image {"sizeSlug":"large","style":{"color":{"duotone":["#000","#BFF5A5"]}}} --> | |||
<!-- wp:image {"sizeSlug":"large"} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the theme.json
for skatepark and see core/image
is using the default duotone filter which is ["#000","#B9FB9C"]
. This image uses a slightly different (more muted) green of #BFF5A5
. I'm not sure if that was originally intentional or a mistake. I don't think anyone would notice the change, but I wanted to point it out here to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a precedent for changing from #BFF5A5
to #B9FB9C
, and honestly can't imagine someone would visually notice the distinction between the two, so I don't think this should be a blocker.
I used the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is a good change. The bug where the filter is missing on the editor for the patterns is a duotone issue that we should fix in the editor. I will look for the issue and if there is none I'll open one.
This is the one! WordPress/gutenberg#48586 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool work! LGTM, also noted that issue y'all already caught above with the post editor.
Changes proposed in this Pull Request:
Remove unnecessary block-level duotone filters in skatepark—these filters are already applied globally.
Additionally, it will be easier to use these patterns in other themes since the custom duotone won't be attached.