Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alignment rules #5526

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Update alignment rules #5526

merged 2 commits into from
Feb 15, 2022

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Feb 14, 2022

Changes proposed in this Pull Request:

This updates the alignment rules from #5487 in all block themes.

To test add the "Image with description and right-aligned headline" pattern from Archeo and check that on mobile the edges look correct:

Before After
Screen Shot 2022-02-09 at 12 50 55 PM Screen Shot 2022-02-09 at 12 50 40 PM

@scruffian scruffian mentioned this pull request Feb 14, 2022
@scruffian scruffian requested a review from a team February 14, 2022 10:36
@scruffian scruffian self-assigned this Feb 14, 2022
@scruffian scruffian requested a review from kjellr February 14, 2022 10:36
@scruffian scruffian marked this pull request as ready for review February 14, 2022 10:37
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in all themes affected and LGTM.

@jffng jffng merged commit 762fa3f into trunk Feb 15, 2022
@jffng jffng deleted the update/alignment-rules branch February 15, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants