Archeo: Add pattern 6 #5487
Archeo: Add pattern 6 #5487
Conversation
archeo/inc/patterns/image-with-description-and-right-aligned-headline.php
Outdated
Show resolved
Hide resolved
archeo/inc/patterns/image-with-description-and-right-aligned-headline.php
Show resolved
Hide resolved
|
Thanks for the review @jffng I've addressed your feedback, so ready for another look :) |
|
Looking good, I still encounter the block validation error when inserting, maybe someone else can verify. |
archeo/style.css
Outdated
| @@ -113,6 +113,7 @@ body > .is-root-container, | |||
| .edit-post-visual-editor__post-title-wrapper, | |||
| .wp-block-group.alignfull, | |||
| .wp-block-group.has-background, | |||
| .wp-block-columns.alignfull.has-background, | |||
There was a problem hiding this comment.
I added this rule because without it, Gutenberg's default padding for columns with a background color is applying and messing up the alignment:
| Before | After |
|---|---|
 |
 |
There was a problem hiding this comment.
We should probably bubble this change up to TT2, Blockbase, Stewart and Livro.
There was a problem hiding this comment.
The padding in the editor is a little too intense — not sure why that doesn't match?
There was a problem hiding this comment.
I missed the equivalent rule for targeting the editor. I added it here: 74bfa70#diff-2769b329cf3d32aab10e3f345c0da915cd1f6d5ffba70ebdeb7c5786597dca3dR119
Do you think these additions make sense? We are saying, "apply the site wide padding and negative margins for columns that are aligned full with a background color".
There was a problem hiding this comment.
Do you think these additions make sense?
Yeah I think this makes sense, especially with the background color applied. Interested to see what anyone else thinks though, in case we're missing something.
There was a problem hiding this comment.
I think it makes sense. But maybe break this out into a separate PR and more thoroughly test it against other themes?
|
I think I've managed to fix the block validation error. I'm not 100% sure exactly what was wrong, but I think it was maybe the hard-coded image IDs and some of the classes? I just re-copied the code from GB until it was happy. |
Nice, it worked, thank you @mikachan ! |
|
Left a small comment above, but otherwise this looks good on my end. Thanks! |
|
Still not sure about this: #5487 (comment) |
|
I took the alignment rule out of this before I merged it, and moved it to #5526 |
Changes proposed in this Pull Request:
Adds pattern 6:
I used the min height fix on the cover block to get the text to align to the bottom of the image.
Related issue(s):