Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: register header and footer colors to Multibranded plugin #2124

Merged
merged 1 commit into from
Jun 8, 2023
Merged

feat: register header and footer colors to Multibranded plugin #2124

merged 1 commit into from
Jun 8, 2023

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Inform the Multibranded site plugin about header and footer color customizations.

How to test the changes in this Pull Request:

  1. Go to the Customize > Header > Appearance and enable the "Solid background" option
  2. Go to the multi branded options and confirm you see 3 new color options (header background, header primary menu and footer background)
  3. Play with these colors and confirm they work as expected

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label May 31, 2023
@leogermani leogermani requested a review from a team as a code owner May 31, 2023 15:46
@leogermani leogermani self-assigned this May 31, 2023
laurelfulford
laurelfulford approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! I tried a few different colour combinations, and cycled through a few themes, and the colours picked up as expected, and reset nicely to the defaults (so they were picking up from the primary colours). 🚢

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jun 8, 2023
@laurelfulford laurelfulford merged commit 7854f97 into master Jun 8, 2023
@laurelfulford laurelfulford deleted the add/header-footer-color-multibranded branch June 8, 2023 16:01
matticbot pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 1.74.0-alpha.1 [skip ci]
243ddbc 
# [1.74.0-alpha.1](v1.73.0...v1.74.0-alpha.1) (2023-06-08)

### Bug Fixes

* correct highlight menu colour ([#2112](#2112)) ([6a18039](6a18039))

### Features

* register header and footer colors to Multibranded plugin ([#2124](#2124)) ([7854f97](7854f97))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.74.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@laurelfulford laurelfulford mentioned this pull request Jun 12, 2023
Merged
6 tasks
matticbot pushed a commit that referenced this pull request Jun 19, 2023
@semantic-release-bot
chore(release): 1.74.0 [skip ci]
2218ac4 
# [1.74.0](v1.73.0...v1.74.0) (2023-06-19)

### Bug Fixes

* correct highlight menu colour ([#2112](#2112)) ([6a18039](6a18039))
* correct typo in the multi-branded site UI ([#2137](#2137)) ([c3106ff](c3106ff))
* move caption check to fix campaigns issue ([#2127](#2127)) ([90e9555](90e9555))

### Features

* register header and footer colors to Multibranded plugin ([#2124](#2124)) ([7854f97](7854f97))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees

@leogermani leogermani

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @laurelfulford